From: Neil Jerram <neil@ossau.uklinux.net>
Cc: djurfeldt@nada.kth.se, guile-devel <guile-devel@gnu.org>
Subject: Re: Critical section review
Date: Thu, 24 Mar 2005 07:30:29 +0000 [thread overview]
Message-ID: <42426C95.3060006@ossau.uklinux.net> (raw)
In-Reply-To: <87acou11xb.fsf@zagadka.de>
Marius Vollmer wrote:
>
> The definition of SCM_NEWSMOB is correct; its prototype is
>
> SCM SCM_NEWSMOB (scm_t_bits tag, scm_t_bits data);
In this case, why does the implementation of SCM_NEWSMOB need a cast?
Surely this cast is likely to hide bad uses of SCM_NEWSMOB.
>
> However, if you want to use a SCM value as the data of a smob, you
> need to use SCM_UNPACK to convert that SCM into a scm_t_bits:
>
> SCM_RETURN_NEWSMOB (scm_tc16_memoized, SCM_UNPACK (scm_cons (exp, env)));
OK, I've done this now, although I think it would be more convenient to
move the SCM_UNPACK into the definition of SCM_RETURN_NEWSMOB.
Neil
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2005-03-24 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 8:16 Critical section review Neil Jerram
2005-03-23 8:58 ` Mikael Djurfeldt
2005-03-23 9:02 ` Mikael Djurfeldt
2005-03-23 20:19 ` Neil Jerram
2005-03-23 20:35 ` Mikael Djurfeldt
2005-03-23 21:34 ` Marius Vollmer
2005-03-24 7:30 ` Neil Jerram [this message]
2005-03-30 18:46 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42426C95.3060006@ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=djurfeldt@nada.kth.se \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).