From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: Critical section review Date: Wed, 23 Mar 2005 20:19:22 +0000 Message-ID: <4241CF4A.8070906@ossau.uklinux.net> References: <424125C0.7000407@ossau.uklinux.net> <66e540fe050323010240b4da11@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1111610047 20431 80.91.229.2 (23 Mar 2005 20:34:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2005 20:34:07 +0000 (UTC) Cc: djurfeldt@nada.kth.se Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 23 21:34:06 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DECTk-0004M2-3v for guile-devel@m.gmane.org; Wed, 23 Mar 2005 21:29:25 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DEClJ-0005UM-05 for guile-devel@m.gmane.org; Wed, 23 Mar 2005 15:47:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DECir-0004ew-51 for guile-devel@gnu.org; Wed, 23 Mar 2005 15:45:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DECig-0004Wu-Pz for guile-devel@gnu.org; Wed, 23 Mar 2005 15:44:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DECig-0004U4-0L for guile-devel@gnu.org; Wed, 23 Mar 2005 15:44:50 -0500 Original-Received: from [80.84.72.33] (helo=mail3.uklinux.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DECK6-0003MY-Om for guile-devel@gnu.org; Wed, 23 Mar 2005 15:19:26 -0500 Original-Received: from laruns (host81-130-189-32.in-addr.btopenworld.com [81.130.189.32]) by mail3.uklinux.net (Postfix) with ESMTP id 276EE409FA6; Wed, 23 Mar 2005 20:19:26 +0000 (UTC) Original-Received: from [127.0.0.1] (laruns [127.0.0.1]) by laruns (Postfix) with ESMTP id DFD3A6F6DC; Wed, 23 Mar 2005 20:19:22 +0000 (GMT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050105 Debian/1.7.5-1 X-Accept-Language: en Original-To: guile-devel In-Reply-To: <66e540fe050323010240b4da11@mail.gmail.com> X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org X-MailScanner-To: guile-devel@m.gmane.org Xref: news.gmane.org gmane.lisp.guile.devel:4866 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4866 Mikael Djurfeldt wrote: > On Wed, 23 Mar 2005 08:16:00 +0000, Neil Jerram wrote: > >>OK, to get the ball rolling and fill in my understanding: >>scm_make_memoized() in debug.c has: >> >> SCM_CRITICAL_SECTION_START; >> SCM_NEWSMOB (z, SCM_UNPACK (exp), SCM_UNPACK (env)); >> SCM_NEWSMOB (ans, scm_tc16_memoized, SCM_UNPACK (z)); >> SCM_CRITICAL_SECTION_END; > > > In addition, the first call to SCM_NEWSMOB is obviously bogus. It > should be a call to scm_cons. Thanks. So this is now just: SCM_RETURN_NEWSMOB (scm_tc16_memoized, scm_cons (exp, env)); which is a completely mechanical change except that one SCM_UNPACK(...) has become ((scm_t_bits) ...) - is the definition of SCM_NEWSMOB correct in using (scm_t_bits) rather than SCM_UNPACK ? Neil _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel