From: "Linus Björnstam" <linus.bjornstam@veryfast.biz>
To: guile-devel@gnu.org
Subject: Re: [PATCH] Add srfi-171 to guile
Date: Sun, 22 Dec 2019 21:45:19 +0100 [thread overview]
Message-ID: <41318438-640c-4d98-8d22-92d320721c0c@www.fastmail.com> (raw)
In-Reply-To: <f4680720-f49f-49c1-aad0-0e0ac3d89932@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
I forgot the copyright!
All the papers are in order with the FSF for the copyright assignment.
--
Linus Björnstam
On Sun, 22 Dec 2019, at 15:55, Linus Björnstam wrote:
> Hi there!
>
> This is a patch to add srfi-171 (transducers) to guile.
>
> It adds the srfi implementation, a guile-specific extension (tfold and
> tbatch which can be used to generalize things like tsegment),
> documentation (the whole srfi document plus additions into
> srfi-modules.texi) and tests.
>
> I have built it successfully on the latest master. This would be my
> first ever commit to a project I did not start myself, with the added
> bonus that I have no idea of how git works. Be kind :)
>
> Happy holidays!
> Linus Björnstam
> Attachments:
> * 0001-Added-srfi-171-to-guile-under-the-module-name-srfi-s.patch
> * 0002-Added-documentation-and-tests-for-srfi-171.patch
[-- Attachment #2: 0001-Added-proper-copyright-to-srfi-171.patch --]
[-- Type: application/octet-stream, Size: 6230 bytes --]
From 12038917c239874baae4baee710419ea2888a86c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Linus=20Bj=C3=B6rnstam?= <linus.bjornstam@fastmail.se>
Date: Sun, 22 Dec 2019 21:42:01 +0100
Subject: [PATCH] Added proper copyright to srfi-171
---
module/srfi/srfi-171.scm | 25 +++++++++++++++----------
module/srfi/srfi-171/gnu.scm | 16 ++++++++++++++++
module/srfi/srfi-171/meta.scm | 24 ++++++++++++++----------
test-suite/tests/srfi-171.test | 17 +++++++++++++++--
4 files changed, 60 insertions(+), 22 deletions(-)
diff --git a/module/srfi/srfi-171.scm b/module/srfi/srfi-171.scm
index 7e8dc603f..a2914d7a9 100644
--- a/module/srfi/srfi-171.scm
+++ b/module/srfi/srfi-171.scm
@@ -1,14 +1,19 @@
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;; Copyright 2019 Linus Björnstam
+;; Copyright (C) 2019 Free Software Foundation, Inc.
;;
-;; You may use this code under either the license in the SRFI document or the
-;; license below.
-;;
-;; Permission to use, copy, modify, and/or distribute this software for any
-;; purpose with or without fee is hereby granted, provided that the above
-;; copyright notice and this permission notice appear in all source copies.
-;; The software is provided "as is", without any express or implied warranties.
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;; This library is free software; you can redistribute it and/or
+;; modify it under the terms of the GNU Lesser General Public
+;; License as published by the Free Software Foundation; either
+;; version 3 of the License, or (at your option) any later version.
+;;
+;; This library is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+;; Lesser General Public License for more details.
+;;
+;; You should have received a copy of the GNU Lesser General Public
+;; License along with this library; if not, write to the Free Software
+;; Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+
;; This module name is guile-specific. The correct module name is of course
diff --git a/module/srfi/srfi-171/gnu.scm b/module/srfi/srfi-171/gnu.scm
index 9aa8ab28e..db4ce76a0 100644
--- a/module/srfi/srfi-171/gnu.scm
+++ b/module/srfi/srfi-171/gnu.scm
@@ -1,3 +1,19 @@
+;; Copyright (C) 2019 Free Software Foundation, Inc.
+;;
+;; This library is free software; you can redistribute it and/or
+;; modify it under the terms of the GNU Lesser General Public
+;; License as published by the Free Software Foundation; either
+;; version 3 of the License, or (at your option) any later version.
+;;
+;; This library is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+;; Lesser General Public License for more details.
+;;
+;; You should have received a copy of the GNU Lesser General Public
+;; License along with this library; if not, write to the Free Software
+;; Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+
(define-module (srfi srfi-171 gnu)
#:use-module (srfi srfi-171)
#:use-module (srfi srfi-171 meta)
diff --git a/module/srfi/srfi-171/meta.scm b/module/srfi/srfi-171/meta.scm
index dd1fd06c4..8f369ef99 100644
--- a/module/srfi/srfi-171/meta.scm
+++ b/module/srfi/srfi-171/meta.scm
@@ -1,14 +1,18 @@
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;; Copyright 2019 Linus Björnstam
+;; Copyright (C) 2019 Free Software Foundation, Inc.
;;
-;; You may use this code under either the license in the SRFI document or the
-;; license below.
-;;
-;; Permission to use, copy, modify, and/or distribute this software for any
-;; purpose with or without fee is hereby granted, provided that the above
-;; copyright notice and this permission notice appear in all source copies.
-;; The software is provided "as is", without any express or implied warranties.
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;; This library is free software; you can redistribute it and/or
+;; modify it under the terms of the GNU Lesser General Public
+;; License as published by the Free Software Foundation; either
+;; version 3 of the License, or (at your option) any later version.
+;;
+;; This library is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+;; Lesser General Public License for more details.
+;;
+;; You should have received a copy of the GNU Lesser General Public
+;; License along with this library; if not, write to the Free Software
+;; Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
;; This module name is guile-specific. The correct name is of course
diff --git a/test-suite/tests/srfi-171.test b/test-suite/tests/srfi-171.test
index c6d574af2..f07941f20 100644
--- a/test-suite/tests/srfi-171.test
+++ b/test-suite/tests/srfi-171.test
@@ -1,5 +1,18 @@
-;; TODO: test all transducers that take an equality predicate
-;; TODO: test treplace with all kinds of hash tables
+;; Copyright (C) 2019 Free Software Foundation, Inc.
+;;
+;; This library is free software; you can redistribute it and/or
+;; modify it under the terms of the GNU Lesser General Public
+;; License as published by the Free Software Foundation; either
+;; version 3 of the License, or (at your option) any later version.
+;;
+;; This library is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+;; Lesser General Public License for more details.
+;;
+;; You should have received a copy of the GNU Lesser General Public
+;; License along with this library; if not, write to the Free Software
+;; Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
(define-module (test-srfi-171)
#:use-module (test-suite lib)
--
2.24.1
next prev parent reply other threads:[~2019-12-22 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 14:55 [PATCH] Add srfi-171 to guile Linus Björnstam
2019-12-22 20:45 ` Linus Björnstam [this message]
2020-01-05 11:30 ` Andy Wingo
2020-01-05 13:34 ` Linus Björnstam
2020-01-16 19:52 ` Linus Björnstam
2020-03-08 14:40 ` Ludovic Courtès
2020-03-08 17:11 ` Linus Björnstam
2020-03-23 17:17 ` Linus Björnstam
2020-03-25 21:48 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41318438-640c-4d98-8d22-92d320721c0c@www.fastmail.com \
--to=linus.bjornstam@veryfast.biz \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).