From: lloda <lloda@sarc.name>
To: "Michael Käppler" <xmichael-k@web.de>
Cc: "guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: Re: [PATCH] Fix error messages containing format strings
Date: Fri, 26 Apr 2024 20:40:23 +0200 [thread overview]
Message-ID: <3730AB7A-A8B0-41E8-9531-4B9304818A23@sarc.name> (raw)
In-Reply-To: <a293821c-3c4d-468b-8472-3e7514a078f0@web.de>
> On 23 Apr 2024, at 10:54, Michael Käppler <xmichael-k@web.de> wrote:
>
> Hi all,
> I recently posted a bug report together with a patch to bug-guile, but
> received no response at all:
>
> https://lists.gnu.org/archive/html/bug-guile/2024-04/msg00000.html
>
> I don't know what the preferred way of reporting bugs and proposing
> patches for Guile is, so
> I'm retrying here on guile-devel.
Hi Michael,
Thanks for looking at this. I think it might be cleaner to use something like
(define (error/args fmt . args)
(error (apply simple-format #f fmt args)))
instead of repeating the pattern every time.
On the other hand it's bad to add more definitions to (ice-9 boot) since they're globally visible. Maybe someone else can suggest a better solution.
regards
Daniel
prev parent reply other threads:[~2024-04-26 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 8:54 [PATCH] Fix error messages containing format strings Michael Käppler
2024-04-26 18:40 ` lloda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3730AB7A-A8B0-41E8-9531-4B9304818A23@sarc.name \
--to=lloda@sarc.name \
--cc=guile-devel@gnu.org \
--cc=xmichael-k@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).