From: "Linus Björnstam" <linus.bjornstam@veryfast.biz>
To: "John Cowan" <cowan@ccil.org>, "Mark H Weaver" <mhw@netris.org>
Cc: srfi <srfi-121@srfi.schemers.org>,
Shiro Kawai <shiro.kawai@gmail.com>,
"Arthur A. Gleckler" <srfi@speechcode.com>,
guile-devel@gnu.org
Subject: Re: [PATCH] add SRFI: srfi-121; generators
Date: Tue, 26 Jan 2021 07:49:35 +0100 [thread overview]
Message-ID: <2f52c109-4ad7-4967-b3d0-12f7590f2dfa@www.fastmail.com> (raw)
In-Reply-To: <e2ab591f-7741-489d-bbb9-011d2905bc63@www.fastmail.com>
Sorry, I though this was in the guile mailing list.
--
Linus Björnstam
On Tue, 26 Jan 2021, at 07:48, Linus Björnstam wrote:
> Hi Y'all!
>
> I have an efficient, almost done implementation of srfi-121. I believe
> it lacks generator-unfold, but that is all. make-coroutine-generator is
> implemented using delimited continuations and runs a lot faster than
> the one in the reference implementation, with the caveat that it is
> apparently slightly incompatible: the coroutine generator usage in
> (srfi 146 hash) yielded the wrong result - despite my version passing
> all tests.
>
> If the maintainers of guile are interested, I could clean this code up
> and add accumulators and make sure it conforms to the srfi document.
>
> I have already spent some time integrating srfi-171 into guile, so I'm
> not entirely unfamiliar with the task.
>
> Best regards
> Linus Björnstam
>
> On Tue, 26 Jan 2021, at 04:29, John Cowan wrote:
> > Note that 121 is withdrawn, so people should implement 158.
> >
> > On Sat, Jan 23, 2021 at 1:38 AM Mark H Weaver <mhw@netris.org> wrote:
> > > Hi Arthur,
> > >
> > > "Arthur A. Gleckler" <srfi@speechcode.com> writes:
> > > > It's not a bad idea for the sample implementation to be as clear as
> > > > possible at the expense of performance.
> > >
> > > I agree that it's desirable for one of the sample implementations to be
> > > as simple and clear as possible, for the purpose of clarifying the
> > > specification.
> > >
> > > > But it certainly wouldn't hurt to have a supplemental document making
> > > > recommendations about possible performance improvements, or even a
> > > > second implementation.
> > >
> > > Sounds good. For SRFIs such as 121 and 158, where efficiency is
> > > important, I think that a second sample implementation tuned for
> > > performance would be a useful addition.
> > >
> > > Regards,
> > > Mark
next prev parent reply other threads:[~2021-01-26 6:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 18:39 [PATCH] add SRFI: srfi-121; generators John Cowan
2021-01-23 0:58 ` Mark H Weaver
2021-01-23 2:14 ` Shiro Kawai
2021-01-23 2:18 ` Arthur A. Gleckler
2021-01-23 6:37 ` Mark H Weaver
2021-01-26 3:29 ` John Cowan
2021-01-26 6:48 ` Linus Björnstam
2021-01-26 6:49 ` Linus Björnstam [this message]
2021-01-26 7:14 ` Marc Nieper-Wißkirchen
2021-01-26 11:54 ` Linus Björnstam
2021-04-08 15:53 ` Arthur A. Gleckler
2021-04-11 6:52 ` Linus Björnstam
2021-04-11 16:17 ` Arthur A. Gleckler
[not found] <mailman.61.1596470427.10776.guile-devel@gnu.org>
2020-08-03 19:41 ` Marc Nieper-Wißkirchen
2020-08-04 12:48 ` Marc Nieper-Wißkirchen
2020-08-04 15:24 ` John Cowan
2020-08-04 15:58 ` Marc Nieper-Wißkirchen
2020-08-04 17:24 ` Dr. Arne Babenhauserheide
-- strict thread matches above, loose matches on Subject: below --
2020-08-01 3:42 John Cowan
2020-08-02 22:39 ` Mark H Weaver
2019-07-01 0:09 nly
2019-07-01 5:06 ` Mark H Weaver
2019-07-01 6:00 ` Mark H Weaver
2019-07-01 6:21 ` Amar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f52c109-4ad7-4967-b3d0-12f7590f2dfa@www.fastmail.com \
--to=linus.bjornstam@veryfast.biz \
--cc=cowan@ccil.org \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
--cc=shiro.kawai@gmail.com \
--cc=srfi-121@srfi.schemers.org \
--cc=srfi@speechcode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).