unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Julian Graham <joolean@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Unicode string normalization
Date: Sun, 3 Jan 2010 01:15:15 -0500	[thread overview]
Message-ID: <2bc5f8211001022215k722228e5wae43c4b23c384ac@mail.gmail.com> (raw)
In-Reply-To: <87skaocdrh.fsf@gnu.org>

Hi Ludovic,

Thanks for the review!

> Looks good to me, please push!

Done.


> +    }
> +  else w_str = (scm_t_uint32 *) scm_i_string_wide_chars (string);
>
> Indentation slightly wrong here.

Huh.  Looked okay in Emacs, but I've re-spaced everything -- hope
that's cleared things up.


Regards,
Julian




  reply	other threads:[~2010-01-03  6:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02  5:38 [PATCH] Unicode string normalization Julian Graham
2010-01-02 23:01 ` Ludovic Courtès
2010-01-03  6:15   ` Julian Graham [this message]
2010-01-03 12:43     ` Andy Wingo
2010-01-05  2:04 ` Mike Gran
2010-01-05 15:00   ` Julian Graham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bc5f8211001022215k722228e5wae43c4b23c384ac@mail.gmail.com \
    --to=joolean@gmail.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).