From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julian Graham Newsgroups: gmane.lisp.guile.devel Subject: Re: More explicit support for Unicode title case Date: Tue, 22 Dec 2009 00:37:59 -0500 Message-ID: <2bc5f8210912212137m132f0d2ag44d39b827a146050@mail.gmail.com> References: <2bc5f8210912210602l5caba56ahb50381f666a59737@mail.gmail.com> <87d428cca7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1261460301 15795 80.91.229.12 (22 Dec 2009 05:38:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Dec 2009 05:38:21 +0000 (UTC) Cc: guile-devel@gnu.org To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Dec 22 06:38:13 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NMxRl-0007w5-2l for guile-devel@m.gmane.org; Tue, 22 Dec 2009 06:38:13 +0100 Original-Received: from localhost ([127.0.0.1]:48411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMxRk-0005JQ-Oo for guile-devel@m.gmane.org; Tue, 22 Dec 2009 00:38:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMxRh-0005Ih-3x for guile-devel@gnu.org; Tue, 22 Dec 2009 00:38:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMxRc-0005HC-BC for guile-devel@gnu.org; Tue, 22 Dec 2009 00:38:08 -0500 Original-Received: from [199.232.76.173] (port=39821 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMxRc-0005H9-4P for guile-devel@gnu.org; Tue, 22 Dec 2009 00:38:04 -0500 Original-Received: from mail-ew0-f224.google.com ([209.85.219.224]:56037) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NMxRZ-0003CN-Dx; Tue, 22 Dec 2009 00:38:01 -0500 Original-Received: by ewy24 with SMTP id 24so6741227ewy.26 for ; Mon, 21 Dec 2009 21:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=KFMCvWhkyBqpclKGwQSL+0cDEmtGLzwO9uMaPKj/e9w=; b=wPuN048VdJxmnYWFBNlrEdGEqc5i98yc+4YY57KzdiD44mRlmQu1c3nGiVk/BRJURq ztYtoRSmBXGmfKgoGQVDZ0RG/P1fcTPzlgPlJxKNmE/3IfuIGRToO0ts793isDLOM6qR BWT46+m01BoLntIhdETyDYE9vkYiY2ZqGe9Is= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hfP8PtYnq6z+IWWPkA4RJYMye2z08l9A0Hbj9DhULsXgIQrCKZpRzzX0DP9+/eaASN nrHPddH0AtoedFqMnnFvzdaaTHA2CRhrvINgrjjXsk6oWdcx5hE0PegimEMyod4N/1Sl UFtPPedP+LzAqx0WuBlCbX990Wgz+b2hNhNhs= Original-Received: by 10.216.91.5 with SMTP id g5mr2999186wef.168.1261460279541; Mon, 21 Dec 2009 21:37:59 -0800 (PST) In-Reply-To: <87d428cca7.fsf@gnu.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9786 Archived-At: Hi Ludovic, Thanks for the feedback! > Please wrap lines to 80 characters. Done. > I=E2=80=99d remove this function altogether because with SRFI-14 one can = just > use =E2=80=98(char-set-contains? char-set:title-case chr)=E2=80=99 if tha= t=E2=80=99s what=E2=80=99s > intended. =C2=A0Given the definition of =E2=80=98char-set:title-case=E2= =80=99, I expect it to > be rarely useful, though. > > What do you think? I agree -- I did think it was weird that (char-title-case? (char-titlecase x)) could sometimes return #f. Done. > At first I wondered how this would differ from =E2=80=98char-upcase=E2=80= =99. =C2=A0IIUC it > differs in a few cases, namely =C7=85 and the other members of > =E2=80=98char-set:title-case=E2=80=99. =C2=A0I think it=E2=80=99d be nice= to mention at least one > example to illustrate the difference. Done. >> +SCM_API scm_t_wchar scm_c_titlecase (scm_t_wchar c); > > I think it should be documented in the manual. Actually, I'm going to hold off on this, since documenting this would require at least some explanation of scm_t_wchar, which seems to me to be outside the scope of this patch. I'm happy to add documentation for this (as well as the other wchar functions), although some context from the originator of that typedef (`git blame' says it was Mike Gran) would be useful. >> + =C2=A0(pass-if "char-locale-titlecase-Dz" > > Maybe =E2=80=9Cchar-locale-titlecase =C7=85=E2=80=9D. Done, although I actually used "D" plus U+017E instead of U+01F1, since Emacs doesn't seem to handle digraphs very well. >> + =C2=A0(pass-if "string-locale-titlecase" >> + =C2=A0 =C2=A0(and (string=3D? "Tt" (string-locale-titlecase "tt")) > > Maybe a longer string otherwise it looks as though it were one of these > special cases. =C2=A0;-) Done, pushed. Thanks, Julian