unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Julian Graham <joolean@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: psyntax error reporting bug
Date: Sun, 18 Oct 2009 18:05:38 -0400	[thread overview]
Message-ID: <2bc5f8210910181505l117961eamd44e78a7e1aea289@mail.gmail.com> (raw)
In-Reply-To: <87pr8k752o.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Hi Ludo,

> Andy is the expert, but I think such a patch can’t hurt, so please do!

Done!  See attached.


Regards,
Julian

[-- Attachment #2: 0001-Fix-typo-in-psyntax.scm-related-to-syntax-violation.patch --]
[-- Type: text/x-diff, Size: 1011 bytes --]

From 48128b32d7f9d9613e46b61a3c695d786152fb67 Mon Sep 17 00:00:00 2001
From: Julian Graham <julian.graham@aya.yale.edu>
Date: Sun, 18 Oct 2009 17:56:13 -0400
Subject: [PATCH] Fix typo in psyntax.scm related to syntax-violation reporting.

* module/ice-9/psyntax.scm (chi-macro): Replace `s' with `(wrap-subst w)'.
---
 module/ice-9/psyntax.scm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/module/ice-9/psyntax.scm b/module/ice-9/psyntax.scm
index cb90fcc..1b5addd 100644
--- a/module/ice-9/psyntax.scm
+++ b/module/ice-9/psyntax.scm
@@ -1323,7 +1323,7 @@
                        (rebuild-macro-output (vector-ref x i) m)))))
               ((symbol? x)
                (syntax-violation #f "encountered raw symbol in macro output"
-                                 (source-wrap e w s mod) x))
+                                 (source-wrap e w (wrap-subst w) mod) x))
               (else x))))
     (rebuild-macro-output (p (wrap e (anti-mark w) mod)) (new-mark))))
 
-- 
1.6.0.4


  reply	other threads:[~2009-10-18 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-18 20:58 psyntax error reporting bug Julian Graham
2009-10-18 21:41 ` Ludovic Courtès
2009-10-18 22:05   ` Julian Graham [this message]
2009-10-19 19:25     ` Andy Wingo
2009-10-19 20:46     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bc5f8210910181505l117961eamd44e78a7e1aea289@mail.gmail.com \
    --to=joolean@gmail.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).