psyntax error reporting bug

psyntax error reporting bug

[Julian Graham]

Hi Guilers,

I'm no psyntax expert, but it looks like there's a minor typo in our
psyntax implementation.  In psyntax.scm, at line 1325 (in
`chi-macro'), the expression:

(syntax-violation #f "encountered raw symbol in macro output"
(source-wrap e w s mod) x)

...should read:

(syntax-violation #f "encountered raw symbol in macro output"
(source-wrap e w (wrap-subst w) mod) x)

...since `s' is not actually in scope -- which, with the former code,
generates an error that obscures the actual syntax violation.  I can
prepare a patch if people want.


Regards,
Julian

Re: psyntax error reporting bug

[Ludovic Courtès]

Hello!

Julian Graham <joolean@gmail.com> writes:

> I'm no psyntax expert, but it looks like there's a minor typo in our
> psyntax implementation.  In psyntax.scm, at line 1325 (in
> `chi-macro'), the expression:
>
> (syntax-violation #f "encountered raw symbol in macro output"
> (source-wrap e w s mod) x)
>
> ...should read:
>
> (syntax-violation #f "encountered raw symbol in macro output"
> (source-wrap e w (wrap-subst w) mod) x)
>
> ...since `s' is not actually in scope

I actually noticed that when testing ‘-Wunbound-variable’:

  ice-9/psyntax-pp.scm:1089:38: warning: possibly unbound variable `s'

But I didn’t take the time to investigate, so I’m glad you did.  :-)

> -- which, with the former code, generates an error that obscures the
> actual syntax violation.  I can prepare a patch if people want.

Andy is the expert, but I think such a patch can’t hurt, so please do!

Thanks,
Ludo’.

Re: psyntax error reporting bug

[Julian Graham]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Hi Ludo,

> Andy is the expert, but I think such a patch can’t hurt, so please do!

Done!  See attached.


Regards,
Julian

[-- Attachment #2: 0001-Fix-typo-in-psyntax.scm-related-to-syntax-violation.patch --]
[-- Type: text/x-diff, Size: 1011 bytes --]

From 48128b32d7f9d9613e46b61a3c695d786152fb67 Mon Sep 17 00:00:00 2001
From: Julian Graham <julian.graham@aya.yale.edu>
Date: Sun, 18 Oct 2009 17:56:13 -0400
Subject: [PATCH] Fix typo in psyntax.scm related to syntax-violation reporting.

* module/ice-9/psyntax.scm (chi-macro): Replace `s' with `(wrap-subst w)'.
---
 module/ice-9/psyntax.scm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/module/ice-9/psyntax.scm b/module/ice-9/psyntax.scm
index cb90fcc..1b5addd 100644
--- a/module/ice-9/psyntax.scm
+++ b/module/ice-9/psyntax.scm
@@ -1323,7 +1323,7 @@
                        (rebuild-macro-output (vector-ref x i) m)))))
               ((symbol? x)
                (syntax-violation #f "encountered raw symbol in macro output"
-                                 (source-wrap e w s mod) x))
+                                 (source-wrap e w (wrap-subst w) mod) x))
               (else x))))
     (rebuild-macro-output (p (wrap e (anti-mark w) mod)) (new-mark))))
 
-- 
1.6.0.4

Re: psyntax error reporting bug

[Andy Wingo]

Hi Julian,

On Mon 19 Oct 2009 00:05, Julian Graham <joolean@gmail.com> writes:

> Done!  See attached.

Looks right to me, please commit :-)

Andy

> From 48128b32d7f9d9613e46b61a3c695d786152fb67 Mon Sep 17 00:00:00 2001
> From: Julian Graham <julian.graham@aya.yale.edu>
> Date: Sun, 18 Oct 2009 17:56:13 -0400
> Subject: [PATCH] Fix typo in psyntax.scm related to syntax-violation reporting.
>
> * module/ice-9/psyntax.scm (chi-macro): Replace `s' with `(wrap-subst w)'.

-- 
http://wingolog.org/

Re: psyntax error reporting bug

[Ludovic Courtès]

Applied, thanks!

Ludo'.