Fix for alloca() usage

Fix for alloca() usage

[carlo.bramix]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hello,
the following files:

libguile/control.c
libguile/fluids.c
libguile/foreign.c
libguile/hashtab.c
libguile/strings.c

require to include <alloca.h>.
Since the alloca.h generated into the /lib directory takes care of various 
configurations, this will fix alloca() usage: after applying the fix, these 
sources will be able to be compiled on Windows since the compiler implements 
_alloca() instead of alloca().
The attached patch has been generated from the latest sources in the 
repository.

Sincerely,

Carlo Bramini.

[-- Attachment #2: guile.txt --]
[-- Type: text/plain, Size: 1847 bytes --]

diff -r -u guile-HEAD-c9b16ce-old/libguile/control.c guile-HEAD-c9b16ce-new/libguile/control.c
--- guile-HEAD-c9b16ce-old/libguile/control.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/control.c	2010-11-19 12:06:52 +0000
@@ -20,6 +20,8 @@
 #  include <config.h>
 #endif
 
+#include <alloca.h>
+
 #include "libguile/_scm.h"
 #include "libguile/control.h"
 #include "libguile/objcodes.h"
diff -r -u guile-HEAD-c9b16ce-old/libguile/fluids.c guile-HEAD-c9b16ce-new/libguile/fluids.c
--- guile-HEAD-c9b16ce-old/libguile/fluids.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/fluids.c	2010-11-19 12:07:06 +0000
@@ -20,6 +20,7 @@
 # include <config.h>
 #endif
 
+#include <alloca.h>
 #include <stdio.h>
 #include <string.h>
 
diff -r -u guile-HEAD-c9b16ce-old/libguile/foreign.c guile-HEAD-c9b16ce-new/libguile/foreign.c
--- guile-HEAD-c9b16ce-old/libguile/foreign.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/foreign.c	2010-11-19 12:07:15 +0000
@@ -22,6 +22,7 @@
 
 #include <ffi.h>
 
+#include <alloca.h>
 #include <alignof.h>
 #include <string.h>
 #include <assert.h>
diff -r -u guile-HEAD-c9b16ce-old/libguile/hashtab.c guile-HEAD-c9b16ce-new/libguile/hashtab.c
--- guile-HEAD-c9b16ce-old/libguile/hashtab.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/hashtab.c	2010-11-19 12:07:24 +0000
@@ -23,6 +23,7 @@
 #endif
 
 #include <stdio.h>
+#include <alloca.h>
 #include <assert.h>
 
 #include "libguile/_scm.h"
diff -r -u guile-HEAD-c9b16ce-old/libguile/strings.c guile-HEAD-c9b16ce-new/libguile/strings.c
--- guile-HEAD-c9b16ce-old/libguile/strings.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/strings.c	2010-11-19 12:07:34 +0000
@@ -22,6 +22,7 @@
 # include <config.h>
 #endif
 
+#include <alloca.h>
 #include <string.h>
 #include <stdio.h>
 #include <ctype.h>

Re: Fix for alloca() usage

[Ludovic Courtès]

Hi,

"carlo.bramix@libero.it" <carlo.bramix@libero.it> writes:

> the following files:
>
> libguile/control.c
> libguile/fluids.c
> libguile/foreign.c
> libguile/hashtab.c
> libguile/strings.c
>
> require to include <alloca.h>.
> Since the alloca.h generated into the /lib directory takes care of various 
> configurations, this will fix alloca() usage: after applying the fix, these 
> sources will be able to be compiled on Windows since the compiler implements 
> _alloca() instead of alloca().
> The attached patch has been generated from the latest sources in the 
> repository.

Applied, thanks!

Ludo’.