unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "carlo.bramix@libero.it" <carlo.bramix@libero.it>
To: guile-devel@gnu.org
Subject: Fix for alloca() usage
Date: Fri, 19 Nov 2010 13:21:31 +0100 (CET)	[thread overview]
Message-ID: <27315848.3019331290169291262.JavaMail.defaultUser@defaultHost> (raw)

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hello,
the following files:

libguile/control.c
libguile/fluids.c
libguile/foreign.c
libguile/hashtab.c
libguile/strings.c

require to include <alloca.h>.
Since the alloca.h generated into the /lib directory takes care of various 
configurations, this will fix alloca() usage: after applying the fix, these 
sources will be able to be compiled on Windows since the compiler implements 
_alloca() instead of alloca().
The attached patch has been generated from the latest sources in the 
repository.

Sincerely,

Carlo Bramini.

[-- Attachment #2: guile.txt --]
[-- Type: text/plain, Size: 1847 bytes --]

diff -r -u guile-HEAD-c9b16ce-old/libguile/control.c guile-HEAD-c9b16ce-new/libguile/control.c
--- guile-HEAD-c9b16ce-old/libguile/control.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/control.c	2010-11-19 12:06:52 +0000
@@ -20,6 +20,8 @@
 #  include <config.h>
 #endif
 
+#include <alloca.h>
+
 #include "libguile/_scm.h"
 #include "libguile/control.h"
 #include "libguile/objcodes.h"
diff -r -u guile-HEAD-c9b16ce-old/libguile/fluids.c guile-HEAD-c9b16ce-new/libguile/fluids.c
--- guile-HEAD-c9b16ce-old/libguile/fluids.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/fluids.c	2010-11-19 12:07:06 +0000
@@ -20,6 +20,7 @@
 # include <config.h>
 #endif
 
+#include <alloca.h>
 #include <stdio.h>
 #include <string.h>
 
diff -r -u guile-HEAD-c9b16ce-old/libguile/foreign.c guile-HEAD-c9b16ce-new/libguile/foreign.c
--- guile-HEAD-c9b16ce-old/libguile/foreign.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/foreign.c	2010-11-19 12:07:15 +0000
@@ -22,6 +22,7 @@
 
 #include <ffi.h>
 
+#include <alloca.h>
 #include <alignof.h>
 #include <string.h>
 #include <assert.h>
diff -r -u guile-HEAD-c9b16ce-old/libguile/hashtab.c guile-HEAD-c9b16ce-new/libguile/hashtab.c
--- guile-HEAD-c9b16ce-old/libguile/hashtab.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/hashtab.c	2010-11-19 12:07:24 +0000
@@ -23,6 +23,7 @@
 #endif
 
 #include <stdio.h>
+#include <alloca.h>
 #include <assert.h>
 
 #include "libguile/_scm.h"
diff -r -u guile-HEAD-c9b16ce-old/libguile/strings.c guile-HEAD-c9b16ce-new/libguile/strings.c
--- guile-HEAD-c9b16ce-old/libguile/strings.c	2010-11-18 20:48:55 +0000
+++ guile-HEAD-c9b16ce-new/libguile/strings.c	2010-11-19 12:07:34 +0000
@@ -22,6 +22,7 @@
 # include <config.h>
 #endif
 
+#include <alloca.h>
 #include <string.h>
 #include <stdio.h>
 #include <ctype.h>

             reply	other threads:[~2010-11-19 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 12:21 carlo.bramix [this message]
2010-11-19 13:29 ` Fix for alloca() usage Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27315848.3019331290169291262.JavaMail.defaultUser@defaultHost \
    --to=carlo.bramix@libero.it \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).