From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Linus_Bj=C3=B6rnstam?= Newsgroups: gmane.lisp.guile.devel Subject: Re: guile pipeline do-over Date: Tue, 10 Mar 2020 09:54:25 +0100 Message-ID: <26cad467-5204-4f2c-80c2-d8032887aa7a@www.fastmail.com> References: <8736al24jt.fsf@verum.com> <87imjgi2vs.fsf@gnu.org> <877dzsy84v.fsf@verum.com> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104609"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.1.7-991-g5a577d3-fmstable-20200305v3 Cc: Guile Devel To: "Rutger van Beusekom" , =?UTF-8?Q?Ludovic_Court=C3=A8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Tue Mar 10 09:55:27 2020 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBafe-000R5y-DR for guile-devel@m.gmane-mx.org; Tue, 10 Mar 2020 09:55:26 +0100 Original-Received: from localhost ([::1]:55552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBafd-0006hv-Cj for guile-devel@m.gmane-mx.org; Tue, 10 Mar 2020 04:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50553) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBaf9-0006gV-VR for guile-devel@gnu.org; Tue, 10 Mar 2020 04:54:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBaf7-00076I-DB for guile-devel@gnu.org; Tue, 10 Mar 2020 04:54:55 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60757) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBaf7-0006wZ-0U; Tue, 10 Mar 2020 04:54:53 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DB48422008; Tue, 10 Mar 2020 04:54:48 -0400 (EDT) Original-Received: from imap1 ([10.202.2.51]) by compute7.internal (MEProxy); Tue, 10 Mar 2020 04:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=veryfast.biz; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type:content-transfer-encoding; s=fm2; bh=f4J5m GhbZBA3GtqoBwj2VJMeTVxEDe/np0GNOiYIzlo=; b=c9zuhqHxAMLOYawBzdIfB ZVd/YxhVCr4AkDlzIKavVB1puo7cl6teN70D4lkLqAn5GP3twvRdSEwAu+etAr1Q mxXe4YJdSJOL+5ClhsdLuepvMP1r5J5GGuKkTI4MkbeB5fsUwfRAZsgPJffqmtzk aKG7RfAMWPiuwW5JptHJ3OfCmxvSUU5buajuP7ObLk0LSqkTVVTHVbb6XJGlWwWH yXNQHP6bB4/xiW4WqQEbtEBHXawItzSUpCNqksJQHdk5bQ7I72ke+R+l2o2WFLvd yJJOHkeNMgoM13FG+h2kKdY+eaXwaHgNtj/8neqIlH9Y0WZG8iFPTzzI14P57V6t g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=f4J5mGhbZBA3GtqoBwj2VJMeTVxEDe/np0GNOiYIz lo=; b=nSTk7B1bORwHIpHcI2QVuzgf5S/vouV71L2zVWCQMFF0k7Si3WT8CtEwu dRfN248SCYCpjn+5N9fBE84ipquYBep59gGb7XjcR64W16fayvE24bIMz8vHLK3g vlygDOh78goqHIsAftOPxzIzbgmtp9CA+GKLkbYtcbYeKwcgk+woZD/UxD/Ebawg /AIzp/Q1NgIYyyY2ro/tb30cHjUQRmf8a7rO1kcfPg9GtphNu8vjza6I5mgC5Ytm 0708xmWjKCXW0rI5gTbgBv6Exq2l0eEhWJjvLmClo1KpxHJxb5X5Fu79rTFX8Glu 8NlNruCG5WZNYYQZlG02plhylMv9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduledguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepnfhi nhhushgpuehjnphrnhhsthgrmhcuoehlihhnuhhsrdgsjhhorhhnshhtrghmsehvvghrhi hfrghsthdrsghiiieqnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheplhhinhhushdrsghjohhrnhhsthgrmhesvhgvrhihfhgrshhtrdgsihii X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 73E93C200A4; Tue, 10 Mar 2020 04:54:48 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <877dzsy84v.fsf@verum.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20442 Archived-At: I have a question about the interface. It uses the shell now, it seems. = (I could be wrong). The guile system call has a (system cmd ) which uses= the shell and a system* call which takes (system* cmd arg ...) So that = it does not rely on the shell. Maybe a similar interface could be useful= (and more secure) for the pipeline as well. Thank you for this patch. Linus Bj=C3=B6rnstam On Tue, 10 Mar 2020, at 08:35, Rutger van Beusekom wrote: >=20 > Hi Ludo, >=20 > I have processed your feedback in this version of the patch. >=20 > Ludovic Court=C3=A8s writes: >=20 > > Hi Rutger! > > > >> ... > > Nice! That=E2=80=99s definitely very useful to have. We=E2=80=99ll= need to check what > > Andy thinks, but I think it can be added in the 3.0 series. > > > > > >> ... > > Could you mention functions renamed/removed here? The ChangeLog for= mat > > is about boringly listing all the language-entity-level changes. :-= ) > > > Done. > > > >> ... > > I guess you can remove the commented-out bits=E2=80=A6 > > > Yep. > > > >> ... > > =E2=80=A6 and this hunk, to minimize change. > > > Check. > > > >> ... > > I would not export =E2=80=98pipe->fdes=E2=80=99. I=E2=80=99m not su= re about exporting > > =E2=80=98piped-process=E2=80=99: it=E2=80=99s a bit low-level and we= might want to reserve > > ourselves the possibility to change it, like this patch does actuall= y. > > > > WDYT? > > > I agree. > >> ... > > > > Please wrap lines to 80 chars. > > > Taken care of. > > > >> ... > > > > I suggest using =E2=80=98string=3D?=E2=80=99 above instead of =E2=80= =98equal?=E2=80=99. Also, could you > > add a docstring? > > > Yes and yes. > > > >> ... > > > > Perhaps s/procs/commands/ would be clearer? Also, @var{commands} > > instead of @code. > > > Yep. > > > > Could you also add an entry in doc/ref/*.texi, in the =E2=80=9CPipes= =E2=80=9D node, > > perhaps with one of the examples you gave? > > > Wrote a new example. WDYT? > > > >> ... > > > > Please move these to the top-level =E2=80=98define-module=E2=80=99 f= orm. > > > Done. > > > > One last thing: we=E2=80=99d need you to assign copyright to the FSF= for this. > > We can discuss it off-line if you want. > > > Can you help me there? I already have a verbal commitment from the > company, we just need to formalize it. > > > > Thank you for this great and long overdue addition! > > > Happy to add it. > > > > Ludo=E2=80=99. > > > Rutger >=20 >=20 > Attachments: > * 0001-Add-pipeline-procedure.patch