From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Gran Newsgroups: gmane.lisp.guile.devel Subject: =?utf-8?q?Re=3A_Optimization_=26_factorization_of_=E2=80=98write?= =?utf-8?b?4oCZ?= Date: Wed, 15 Sep 2010 07:28:50 -0700 (PDT) Message-ID: <257144.86099.qm@web37904.mail.mud.yahoo.com> References: <877hiowglj.fsf@gnu.org> <455480.11700.qm@web37907.mail.mud.yahoo.com> <87r5gwrvfn.fsf@gnu.org> <227537.62931.qm@web37907.mail.mud.yahoo.com> <87sk1bgrpe.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1284560969 20218 80.91.229.12 (15 Sep 2010 14:29:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Sep 2010 14:29:29 +0000 (UTC) To: =?utf-8?B?THVkb3ZpYyBDb3VydMOocw==?= , guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 15 16:29:23 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OvszD-0007Ju-9l for guile-devel@m.gmane.org; Wed, 15 Sep 2010 16:29:23 +0200 Original-Received: from localhost ([127.0.0.1]:35332 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvszC-0005iR-P2 for guile-devel@m.gmane.org; Wed, 15 Sep 2010 10:29:22 -0400 Original-Received: from [140.186.70.92] (port=58609 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ovsyu-0005ZH-AE for guile-devel@gnu.org; Wed, 15 Sep 2010 10:29:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ovsyi-0004zI-Cr for guile-devel@gnu.org; Wed, 15 Sep 2010 10:29:04 -0400 Original-Received: from web37904.mail.mud.yahoo.com ([209.191.91.166]:24775) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Ovsyi-0004yo-7L for guile-devel@gnu.org; Wed, 15 Sep 2010 10:28:52 -0400 Original-Received: (qmail 94482 invoked by uid 60001); 15 Sep 2010 14:28:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1284560931; bh=iXVCQSNb0aQoBLOl2Lj1CKpFMJc63x+iRya9Gq/+4XM=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=DXtFWJt9G9rSbjGoezNLZbqyp7rttWq6qnadd7Q++vTgRyzXIAEEqGtI+4Zzr6OsI69a2kW9wW2lqQnZBhJqVk1HZOnBwsLFCvqCdkjxcXIzb2PWQKDcqWWgWaiBDPyo8ENokhYauezuSHxOcVzUtCiG4fWI0N4Pe0CNTVeZIes= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=0fG9cPQIlqHUT2Fid2qAIXcuTa+srBhK9Ku7NGMcwthnTkJNDgzsP6SPgvSckrIGsPm0cW/MTgAL4zl8/NP9Y57ogzKW9MXP9Vm0o2ipVwBoB/02Ku18hcRX5tiPlgwtlA4oSTNLhljuduNQAMmJ02A9P/quC+eugoL4Y4GCuT8=; X-YMail-OSG: WpPVtQEVM1lkI.veNlzjW.qXFwb1SbjCqcqnNRPHEakSiXc KRl5de1ff Original-Received: from [71.130.212.104] by web37904.mail.mud.yahoo.com via HTTP; Wed, 15 Sep 2010 07:28:50 PDT X-Mailer: YahooMailRC/470 YahooMailWebService/0.8.105.279950 In-Reply-To: <87sk1bgrpe.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: FreeBSD 6.x (1) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10918 Archived-At: > From: Ludovic Court=C3=A8s =0A=0A=0A> Hi,=0A> =0A> Mike Gra= n writes:=0A> =0A> > I have the attached. It is not rea= lly a test because it doesn't=0A> > have criteria for right and wrong, but= , you can diff the changes=0A> > of the output files after committing to s= ee if output formats=0A> > have stayed the same.=0A> =0A> OK, interesting.= Any idea how well it covers the display/write code=0A> compared to the t= est suite?=0A=0ANo. That's a good question. I had done this type of scrip= t testing=0Awhen I was hacking the code, but, now, if there are any corner = cases=0Athat this catches, they should be rolled into the test suite.=0A=0A= > =0A> > But I tried it just now on HEAD, and it triggered a 'glibc detect= ed=0A> > corrupteddouble-linked list' error. Curious.=0A> =0A> Hmm indeed= . Can you come up with a reduced test case and perhaps a=0A> backtrace or= something?=0A> =0A=0Ain scm_i_unistring_escapes_to_r6rs_escapes(), you c= an have a write=0Aoff the end of a string when the buffer passed into the f= unction contains=0Aonly 4-digit hex unistring hex escapes, such as "\u1100"= . The=0AR6RS-escaped string will be longer "\x1100;" causing the memcpy at= the=0Aend of the function to write off then end of the string.=0A=0AThanks= ,=0A=0AMike