From: Jonas Hahnfeld via "Developers list for Guile, the GNU extensibility library" <guile-devel@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>, guile-devel@gnu.org
Subject: Re: GC + Java finalization
Date: Fri, 19 Nov 2021 14:40:16 +0100 [thread overview]
Message-ID: <21fe294b75b001afbd1be0e972a19ddb7187e98b.camel@hahnjo.de> (raw)
In-Reply-To: <b30df7ea995c0fa64ea7551fba4b179f3013687f.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Am Freitag, dem 19.11.2021 um 13:35 +0000 schrieb Maxime Devos:
> Jonas Hahnfeld schreef op vr 19-11-2021 om 14:32 [+0100]:
> > > You coud simply ...
> > >
> > >
> > > > - scm_gc_free (rx, sizeof(regex_t), "regex");
> > > > + free (rx);
> > >
> > > drop the scm_gc_free AFAIK.
> >
> > No, I cannot as explained in the patch summary: If we use
> > scm_gc_free
> > in a free function of a Smob, this relies on Java finalization
> > because
> > the memory must not be reclaimed in the same cycle.
>
> The suggestion was to remove scm_gc_free, and not introduce free.
> I.e., don't free rx manually at all, let boehmgc decide:
>
> regex_free (SCM obj)
> {
> regfree (SCM_RGX (obj));
> - scm_gc_free (SCM_RGX (obj), sizeof(regex_t), "regex");
> return 0;
> }
This is dangerous because we still pass the memory to regfree, so it
must not be freed before.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-19 13:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 12:05 GC + Java finalization Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 17:14 ` Maxime Devos
2021-07-03 17:26 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-07-03 18:49 ` Maxime Devos
2021-07-03 18:54 ` Maxime Devos
2021-07-15 18:44 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-10-10 16:22 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 12:18 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2022-02-22 10:14 ` Dr. Arne Babenhauserheide
2022-02-22 15:12 ` Mike Gran
2021-11-19 13:13 ` Maxime Devos
2021-11-19 13:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:35 ` Maxime Devos
2021-11-19 13:40 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library [this message]
2021-11-19 13:44 ` Maxime Devos
2021-11-19 13:53 ` Maxime Devos
2021-11-19 13:53 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:01 ` Maxime Devos
2021-11-19 13:48 ` Maxime Devos
2021-11-19 13:55 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:14 ` Maxime Devos
2021-11-19 14:52 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 18:48 ` Maxime Devos
2021-11-19 19:01 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:15 ` Maxime Devos
2021-11-19 13:35 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 14:21 ` Maxime Devos
2021-11-19 15:32 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-19 13:17 ` Maxime Devos
2021-11-19 13:38 ` Jonas Hahnfeld via Developers list for Guile, the GNU extensibility library
2021-11-20 9:19 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fe294b75b001afbd1be0e972a19ddb7187e98b.camel@hahnjo.de \
--to=guile-devel@gnu.org \
--cc=hahnjo@hahnjo.de \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).