From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxime Devos Newsgroups: gmane.lisp.guile.devel Subject: RE: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions. Date: Fri, 20 Dec 2024 16:15:43 +0100 Message-ID: <20241220161547.r3Fm2D00N2kJuzj013FmRb@andre.telenet-ops.be> References: <43ad0b39-03cf-b648-3bc9-8c4a064519a8@disroot.org> <8e113f49-c1dc-313b-e65a-24a73c5b887a@disroot.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_1196F79D-DDFF-42E9-B6C6-A834606EA45F_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13602"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "guile-devel@gnu.org" , Mikael Djurfeldt To: "mikael@djurfeldt.com" , Adam Faiz Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Dec 20 16:16:11 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOeja-0003KM-Ty for guile-devel@m.gmane-mx.org; Fri, 20 Dec 2024 16:16:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOejM-0005be-DB; Fri, 20 Dec 2024 10:15:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOejH-0005bL-Ui for guile-devel@gnu.org; Fri, 20 Dec 2024 10:15:52 -0500 Original-Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOejF-0003T9-4F for guile-devel@gnu.org; Fri, 20 Dec 2024 10:15:51 -0500 Original-Received: from [IPv6:2a02:1811:8c0e:ef00:f87b:b2ea:4352:aa46] ([IPv6:2a02:1811:8c0e:ef00:f87b:b2ea:4352:aa46]) by andre.telenet-ops.be with cmsmtp id r3Fm2D00N2kJuzj013FmRb; Fri, 20 Dec 2024 16:15:46 +0100 Importance: normal X-Priority: 3 In-Reply-To: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r24; t=1734707747; bh=/LB2jjIRemZBHxmqAwkZ0m8stSvWdweOQn11zQHWMdQ=; h=Message-ID:MIME-Version:To:Cc:From:Subject:Date:In-Reply-To: References:Content-Type:From; b=jm5EMyTWaoT8xeOUHK7c95sCEEFEMe+b1lP7U/rV8ZMQ/FmCDQDYA3xDXq+LRdJz3 IHmbWFVx/bWSlJY4eanb6P2HV67aHNJNI+EGRoxrjhSFgSdzobfCDOPjprZ63uP8Lg NX9n9s8S5nqw7uIIsX9qG8/hX1ePdNSss777yAZwKL+ccV0X4pVO/WjNpLXicSLOO/ 8m3/RA3n8bDjRPotUXjxg8M+GJnWF65J+pI/DVrxhhGljO88BP+/dUEGehaUz144Ye MKMZ5EXAHAs9FukKxaeZcxRTY6sRE8U0HF3yaMZMoP47/pjL5h60BwgwKWxZJ1bj4A m/tQ8k3JE6CEg== Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22855 Archived-At: --_1196F79D-DDFF-42E9-B6C6-A834606EA45F_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" > Thanks for your patches! Applied now. Regardless of the question whether to generalise, there was also the thing = about the test testing for returning #true even though this behaviour isn= =E2=80=99t documented anywhere. Also, there was the thing about needing to = verify whether (ice-9 rdelim) always recognises \n or whether that=E2=80=99= s Unix-dependent (if the latter, (ice-9 rdelim) or the test needs to be adj= usted, and in case of the former the documentation needs to be adjusted). Best regards, Mikael --_1196F79D-DDFF-42E9-B6C6-A834606EA45F_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

> Thanks for your patches! Applied now.

 =

Regardless of the = question whether to generalise, there was also the thing about the test tes= ting for returning #true even though this behaviour isn=E2=80=99t documente= d anywhere. Also, there was the thing about needing to verify whether (ice-= 9 rdelim) always recognises \n or whether that=E2=80=99s Unix-dependent (if= the latter, (ice-9 rdelim) or the test needs to be adjusted, and in case o= f the former the documentation needs to be adjusted).

=

 

<= div>

Best regards,=

Mikael

 = --_1196F79D-DDFF-42E9-B6C6-A834606EA45F_--