From: Maxime Devos <maximedevos@telenet.be>
To: "mikael@djurfeldt.com" <mikael@djurfeldt.com>,
Adam Faiz <adam.faiz@disroot.org>
Cc: "guile-devel@gnu.org" <guile-devel@gnu.org>,
Mikael Djurfeldt <mikael@djurfeldt.com>
Subject: RE: [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions.
Date: Fri, 20 Dec 2024 16:15:43 +0100 [thread overview]
Message-ID: <20241220161547.r3Fm2D00N2kJuzj013FmRb@andre.telenet-ops.be> (raw)
In-Reply-To: <CAA2XvwJD-svjEQBWfRkKQh=bsLSdjQD1u=9ge0nr3ziVBzB3Lg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
> Thanks for your patches! Applied now.
Regardless of the question whether to generalise, there was also the thing about the test testing for returning #true even though this behaviour isn’t documented anywhere. Also, there was the thing about needing to verify whether (ice-9 rdelim) always recognises \n or whether that’s Unix-dependent (if the latter, (ice-9 rdelim) or the test needs to be adjusted, and in case of the former the documentation needs to be adjusted).
Best regards,
Mikael
[-- Attachment #2: Type: text/html, Size: 1933 bytes --]
next prev parent reply other threads:[~2024-12-20 15:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 15:21 [PATCH 1/2] rdelim: Add new procedure `for-rdelim-in-port` Adam Faiz
2024-12-16 15:24 ` [PATCH 2/2] doc: Add documentation for `for-rdelim-in-port` and, related procedures Adam Faiz
2024-12-17 4:31 ` [PATCH] test-suite: Add tests for `for-rdelim-in-port`-related functions Adam Faiz
2024-12-17 5:11 ` Nala Ginrut
2024-12-17 7:21 ` Mikael Djurfeldt
2024-12-17 16:43 ` Mikael Djurfeldt
2024-12-20 9:15 ` Maxime Devos
2024-12-20 9:57 ` Nala Ginrut
2024-12-20 11:51 ` Maxime Devos
2024-12-20 12:00 ` Nala Ginrut
2024-12-20 12:53 ` Maxime Devos
2024-12-20 13:00 ` Nala Ginrut
2024-12-20 13:45 ` Maxime Devos
2024-12-20 13:52 ` Nala Ginrut
2024-12-20 14:18 ` Maxime Devos
2024-12-20 14:30 ` Nala Ginrut
2024-12-20 14:32 ` Nala Ginrut
2024-12-20 14:47 ` Maxime Devos
2024-12-20 14:56 ` Nala Ginrut
2024-12-20 15:07 ` Maxime Devos
2024-12-20 15:13 ` Nala Ginrut
2024-12-19 21:50 ` Mikael Djurfeldt
2024-12-20 15:15 ` Maxime Devos [this message]
2024-12-20 17:11 ` [PATCH] test-suite: Add tests for `for-rdelim-in-port`-relatedfunctions Mikael Djurfeldt
2024-12-20 17:31 ` Nala Ginrut
2024-12-20 18:40 ` Maxime Devos
2024-12-16 16:46 ` [PATCH 1/2] rdelim: Add new procedure `for-rdelim-in-port` Nala Ginrut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220161547.r3Fm2D00N2kJuzj013FmRb@andre.telenet-ops.be \
--to=maximedevos@telenet.be \
--cc=adam.faiz@disroot.org \
--cc=guile-devel@gnu.org \
--cc=mikael@djurfeldt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).