From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Denis 'GNUtoo' Carikli Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon. Date: Fri, 12 Apr 2024 17:19:22 +0200 Message-ID: <20240411024107.222b5cc0@primary_laptop> References: <20240229212343.10442-1-GNUtoo@cyberdimension.org> <87r0gnjj7h.fsf@trouble.defaultvalue.org> <20240311192508.5b974e64@trisquel64> <87r0g57ny8.fsf@trouble.defaultvalue.org> <87h6gf4gd2.fsf@trouble.defaultvalue.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/A4mFxyRV2gWTFaJM680grOc"; protocol="application/pgp-signature"; micalg=pgp-sha256 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26093"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Rob Browning Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Fri Apr 12 17:20:41 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvIhh-0006UA-43 for guile-devel@m.gmane-mx.org; Fri, 12 Apr 2024 17:20:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvIhP-0005df-OM; Fri, 12 Apr 2024 11:20:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvIhK-0005dP-9v for guile-devel@gnu.org; Fri, 12 Apr 2024 11:20:14 -0400 Original-Received: from cyberdimension.org ([2001:678:938:3ff::36] helo=rockpro64.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1rvIhB-0003tM-5i for guile-devel@gnu.org; Fri, 12 Apr 2024 11:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=dkim; bh=CqpgTN3617wAkCe p0DkxNZw3cki01zNxzCI+8rpeLAo=; h=references:in-reply-to:subject:cc:to: from:date; d=cyberdimension.org; b=a/yGA1wAL7dgbwGOFPQvE018q8XZTX34pDU V52OEBrcWFKKYgjqwSIGEhczCyYRt+EkOn0YbERQr8eqCXDVj0P3cTGAXVeKfVnTqlxZn/ xXWmuCJcuNA5KI9S+xBom9muQOtpD8YqJsXS3aGSludk/D3Zf4AomgxpAqtpSyZq37r95i OlOfKCnBej0nVGu+BrHXA3VTyTGjw6aWyEwKzDmqtd2s1xagzcXfaCFwZ/m3YhenDVJ0j4 YucKCvSnhaKx/Ehn4ee3y7pPzChYZKAwpZ1otXYJ691ya2XJzxLE1zRaZ7/WbpY1s4mv/X vv+eTpNMe7W+sc8Swdt1uMS+I8Q== Original-Received: from primary_laptop (localhost [127.0.0.1]) by rockpro64.cyberdimension.org (OpenSMTPD) with ESMTP id 8819c63a; Fri, 12 Apr 2024 15:19:31 +0000 (UTC) In-Reply-To: <87h6gf4gd2.fsf@trouble.defaultvalue.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.41; x86_64-pc-linux-gnu) Received-SPF: pass client-ip=2001:678:938:3ff::36; envelope-from=GNUtoo@cyberdimension.org; helo=rockpro64.cyberdimension.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22385 Archived-At: --Sig_/A4mFxyRV2gWTFaJM680grOc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sorry again for the delay, I had personal issues (that are now mostly fixed) that needed urgent attention and that took all my time. On Fri, 05 Apr 2024 17:03:21 -0500 Rob Browning wrote: > Rob Browning writes: >=20 > > Apologies for the delay, and good point. I should have used eqv? > > rather than char=3D?, i.e. > > > > (let ((ch (read-char port))) > > (if (eqv? ch #\:) > > (set! ch (read-char port)) > > (if (eof-object? ch) > > (time-error 'string->date > > 'bad-date-template-string (list "Invalid time zone number" ch))) > > (set! ...)) =20 >=20 > Just checking back -- does that adjustment seem plausible to you?=20 Yes, that makes the code much better and since when ch is eof, '(eqv? ch #\:)' returns #f, so it should work. > If so, I may adjust your patch and proceed with it. Thanks a lot. Denis. --Sig_/A4mFxyRV2gWTFaJM680grOc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmYZUPoACgkQX138wUF3 4mN+jQ/8CHs6K6cG4jB1VhyWb1OGOWU/ZfxaZpdCmI18583M6nM4x1i1SRayldEH IDLWM+z5hCqetuwwoCbxb7fsLXGu2eVao+Auw2SafM5m8drdVdEPWfu4QoT21ywv /MrnAUDIhF3hzi5iSoY4pqkI5Yr8OngHaMSMAMsMQYwEKPWk9Yp7nrnJZIpa9/ZP O0WIJaVj3nuvroPzWqtY9sPzler3xhfL17mlb+T4Hwo75UUW8hViyPiaYY3R0GGe cAtHRKCJoG2b5KhcekcihwwxIcZxbpBbrqBgmYIUKDqAZ9RLn+IU5hYwPQb6uniF YSVf5uzBO4KE//TO79zTHGajsbw+BpMT/vkIfnYRD1Wio0EL93eEaLaZljrcwKDg hVqVbqeD5XL1ccb719t+pcsNh7O0IRZKb06wuf/RXZTnrH3rY9AqIjgMhV3EJAIV CH/D8yMIyL24QA6wUz36fGw23MFLZsGB03eiTcns4X6QbawliiJbmsZ7bj+qWiUd kaIcdx8vZQwpS40G9hQwTbY3D+FESjiAKHgtjsonscEZpDd/qYP6fcMU5NR0CS1b Kq6c+VkHmKqqW0eYcbQrmShAn7gV4iphAu9wFMaw5kozA3Au+UkblPUJi+o1eiJI z7hImJ12tSWnDjdmEe4oYWL20H1+fyLJdepE1zVsVVzuZCDoudc= =vF62 -----END PGP SIGNATURE----- --Sig_/A4mFxyRV2gWTFaJM680grOc--