From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: guile-devel@gnu.org
Cc: David Pirotte <david@altosw.be>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [Guile-Lib PATCH v4 0/7] Make log-msg accept source properties for displaying source location
Date: Sun, 25 Feb 2024 09:19:06 -0500 [thread overview]
Message-ID: <20240225141935.8420-1-maxim.cournoyer@gmail.com> (raw)
The main change of this series is adding the ability to pass source
properties (such as can be obtained via syntax-source in macros, for
example [0]) to the `log-msg' call, and have the default log formatter
use it to display the source location of the corresponding call. The
procedure name where the log-msg call was made is also resolved and
made available to the log formatter.
It also fixes a few minor issues spotted while working with the
source, and calls `flush-log' at the end of `accept-log' to avoid
long delays caused by the default block buffering when the log traffic
is low.
[0] https://issues.guix.gnu.org/68946
Changes in v4:
- Reword commit messages per David's preference
- log-helper's source-properties argument is now a keyword argument
- original accept-log method restored (on top of new one)
Changes in v3:
- Use (ice-9 format) for the default-log-formatter
- Use a keyword argument for the source-properties
- Add proc-name argument to default-log-formatter
Changes in v2:
- Relax log-msg typing on source-properties, as it can also be #f
Maxim Cournoyer (7):
configure.ac: Fix typo in message.
Use /bin/sh in update-api script shebang.
tests: guile-library.api: Re-generate.
logging: Allow passing source properties to `log-msg'.
logging: Adjust default log-formatter output.
logging: Make procedure name available to the log formatter.
logging: Call flush-log at the end of accept-log.
configure.ac | 2 +-
src/logging/logger.scm | 109 ++++++++++-----
unit-tests/guile-library.api | 247 ++--------------------------------
unit-tests/logging.logger.scm | 18 ++-
unit-tests/update-api | 2 +-
5 files changed, 103 insertions(+), 275 deletions(-)
base-commit: 8d0196230f80afcf4da33917fe8ae390a1560931
--
2.41.0
next reply other threads:[~2024-02-25 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 14:19 Maxim Cournoyer [this message]
2024-02-25 14:19 ` [Guile-Lib PATCH v4 1/7] configure.ac: Fix typo in message Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 2/7] Use /bin/sh in update-api script shebang Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 3/7] tests: guile-library.api: Re-generate Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 4/7] logging: Allow passing source properties to `log-msg' Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 5/7] logging: Adjust default log-formatter output Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 6/7] logging: Make procedure name available to the log formatter Maxim Cournoyer
2024-02-25 14:19 ` [Guile-Lib PATCH v4 7/7] logging: Call flush-log at the end of accept-log Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240225141935.8420-1-maxim.cournoyer@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=david@altosw.be \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).