From: Andrew Whatson <whatson@gmail.com>
To: guile-devel@gnu.org
Cc: Andrew Whatson <whatson@gmail.com>
Subject: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.
Date: Thu, 22 Sep 2022 23:53:59 +1000 [thread overview]
Message-ID: <20220922135358.22139-1-whatson@gmail.com> (raw)
In-Reply-To: <56d1283b-ac09-8f62-8657-de99578e1a6c@telenet.be>
Workaround for <https://bugs.gnu.org/57948>.
* module/system/vm/frame.scm (frame-call-representation): Treat a
binding as "unspecified" if its slot exceeds 'frame-num-locals'.
---
module/system/vm/frame.scm | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/module/system/vm/frame.scm b/module/system/vm/frame.scm
index 3be73e29c..e36eb797c 100644
--- a/module/system/vm/frame.scm
+++ b/module/system/vm/frame.scm
@@ -381,8 +381,16 @@
(frame-local-ref frame i 'scm))
((find-slot i bindings)
=> (lambda (binding)
- (let ((val (frame-local-ref frame (binding-slot binding)
- (binding-representation binding))))
+ (let* ((slot (binding-slot binding))
+ ;; HACK: Avoid out-of-range from frame-local-ref.
+ ;; Some frames have bindings beyond nlocals. That
+ ;; is probably a bug somewhere else, but at least
+ ;; this workaround allows them to be printed.
+ ;; See <https://bugs.gnu.org/57948>.
+ (val (if (< slot nlocals)
+ (frame-local-ref frame slot
+ (binding-representation binding))
+ *unspecified*)))
;; It could be that there's a value that isn't clobbered
;; by a call but that isn't live after a call either. In
;; that case, if GC runs during the call, the value will
--
2.37.3
next prev parent reply other threads:[~2022-09-22 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 7:23 [PATCH] Avoid 'frame-local-ref' errors when printing backtrace Andrew Whatson
2022-09-21 10:50 ` Maxime Devos
2022-09-22 13:53 ` Andrew Whatson [this message]
2022-09-22 15:10 ` Maxime Devos
2022-10-12 20:34 ` Ludovic Courtès
2022-10-13 3:36 ` Andrew Whatson
2022-10-13 13:09 ` Ludovic Courtès
2023-01-11 5:24 ` Andrew Whatson
2023-01-11 23:03 ` Ludovic Courtès
2023-01-12 2:09 ` Andrew Whatson
2022-11-29 18:06 ` lloda
2022-09-22 13:58 ` Andrew Whatson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922135358.22139-1-whatson@gmail.com \
--to=whatson@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).