From: Chris Vine <vine24683579@gmail.com>
To: guile-devel@gnu.org
Subject: Re: bug#56867: [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7.
Date: Thu, 4 Aug 2022 18:31:30 +0100 [thread overview]
Message-ID: <20220804183130.09c9e1fbe51e1244aecfc5fa@gmail.com> (raw)
In-Reply-To: <87pmhgks4j.fsf@gnu.org>
On Thu, 04 Aug 2022 16:20:12 +0200
Ludovic Courtès <ludo@gnu.org> wrote:
> Ludovic Courtès <ludo@gnu.org> skribis:
>
> > The custom input/output port wrapping the TLS session record port would
> > introduce overhead, and it would also prevent its uses in a non-blocking
> > context--e.g., with Fibers. The port close mechanism added in GnuTLS
> > 3.7.7 allows us to get rid of that wrapper.
> >
> > * guix/build/download.scm (wrap-record-port-for-gnutls<3.7.7): New
> > procedure, with code formerly in 'tls-wrap'.
> > (tls-wrap): Check for 'set-session-record-port-close!' and use it when
> > available; otherwise call 'wrap-record-port-for-gnutls<3.7.7'.
>
> I synchronized Guile's copy of this code:
>
> 317b06bf8 web: 'tls-wrap' retries handshake upon non-fatal errors.
> c01ca10b3 web: Do not wrap TLS port on GnuTLS >= 3.7.7.
>
> I realized that’s not enough to make it possible to use non-blocking
> ports though.
[snip revised patch]
> Thoughts?
I have not been following these patches and this may be completely
irrelevant, but if the context of these patches is the use of
gnutls-guile, then when I last looked (which was some time ago)
gnutls-guile ports were not suspendable. So a non-blocking
gnutls-guile port will still block when used with guile's suspendable
ports.
If I have missed the point please ignore this.
prev parent reply other threads:[~2022-08-04 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 9:07 [bug#56867] [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7 Ludovic Courtès
2022-08-01 9:15 ` Ludovic Courtès
2022-08-01 9:56 ` Maxime Devos
2022-08-02 7:59 ` Ludovic Courtès
2022-08-04 19:37 ` Maxime Devos
2022-08-05 8:31 ` Ludovic Courtès
2022-08-05 10:17 ` Maxime Devos
2022-08-03 15:57 ` bug#56867: " Ludovic Courtès
2022-08-04 14:20 ` [bug#56867] " Ludovic Courtès
2022-08-04 14:46 ` bug#56005: " Thiago Jung Bauermann via Bug reports for GNU Guix
2022-08-04 16:19 ` Ludovic Courtès
2022-08-04 17:31 ` Chris Vine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804183130.09c9e1fbe51e1244aecfc5fa@gmail.com \
--to=vine24683579@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).