From: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
To: guile-devel@gnu.org
Cc: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
Subject: [PATCH] web: send capitalized authorization header scheme
Date: Fri, 24 Jun 2022 09:05:05 -0700 [thread overview]
Message-ID: <20220624160505.18005-1-aconchillo@gmail.com> (raw)
* module/web/http.scm (write-credentials): capitalize authorization
header scheme. The standard allows the scheme to be case-insensitive,
however most libraries out there expect the scheme to be capitalized,
which is what it is actually used in RFC
docs (e.g. https://datatracker.ietf.org/doc/html/rfc7617#section-2). Some
libraries even reject lowercase scheme making Guile incompatible.
---
module/web/http.scm | 4 ++--
test-suite/tests/web-http.test | 11 ++++++++---
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/module/web/http.scm b/module/web/http.scm
index 4276e1744..312c28934 100644
--- a/module/web/http.scm
+++ b/module/web/http.scm
@@ -965,10 +965,10 @@ as an ordered alist."
(define (write-credentials val port)
(match val
(('basic . cred)
- (put-string port "basic ")
+ (put-string port "Basic ")
(put-string port cred))
((scheme . params)
- (put-symbol port scheme)
+ (put-string port (string-titlecase (symbol->string scheme)))
(put-char port #\space)
(write-key-value-list params port))))
diff --git a/test-suite/tests/web-http.test b/test-suite/tests/web-http.test
index 63377349c..5c6a954b9 100644
--- a/test-suite/tests/web-http.test
+++ b/test-suite/tests/web-http.test
@@ -336,9 +336,14 @@
(pass-if-parse authorization "Digest foooo" '(digest foooo))
(pass-if-parse authorization "Digest foo=bar,baz=qux"
'(digest (foo . "bar") (baz . "qux")))
- (pass-if-round-trip "Authorization: basic foooo\r\n")
- (pass-if-round-trip "Authorization: digest foooo\r\n")
- (pass-if-round-trip "Authorization: digest foo=bar, baz=qux\r\n")
+ (pass-if-parse authorization "basic foooo" '(basic . "foooo"))
+ (pass-if-parse authorization "digest foooo" '(digest foooo))
+ (pass-if-parse authorization "digest foo=bar,baz=qux"
+ '(digest (foo . "bar") (baz . "qux")))
+ (pass-if-round-trip "Authorization: Basic foooo\r\n")
+ (pass-if-round-trip "Authorization: Bearer token\r\n")
+ (pass-if-round-trip "Authorization: Digest foooo\r\n")
+ (pass-if-round-trip "Authorization: Digest foo=bar, baz=qux\r\n")
(pass-if-parse expect "100-continue, foo" '((100-continue) (foo)))
(pass-if-parse from "foo@bar" "foo@bar")
(pass-if-parse host "qux" '("qux" . #f))
--
2.34.1
next reply other threads:[~2022-06-24 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 16:05 Aleix Conchillo Flaqué [this message]
2022-06-24 16:28 ` [PATCH] web: send capitalized authorization header scheme Maxime Devos
2022-06-24 16:35 ` Aleix Conchillo Flaqué
-- strict thread matches above, loose matches on Subject: below --
2022-06-24 16:34 Aleix Conchillo Flaqué
2022-06-24 19:51 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624160505.18005-1-aconchillo@gmail.com \
--to=aconchillo@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).