From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= Newsgroups: gmane.lisp.guile.devel Subject: [PATCH] foreign-library: fix RTLD_LAZY | RTLD_LOCAL crash on macOS Date: Sat, 11 Sep 2021 22:10:24 -0700 Message-ID: <20210912051024.40841-1-aconchillo@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?q?Aleix=20Conchillo=20Flaqu=C3=A9?= To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sun Sep 12 07:11:21 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPHlw-0007vK-S3 for guile-devel@m.gmane-mx.org; Sun, 12 Sep 2021 07:11:20 +0200 Original-Received: from localhost ([::1]:59076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPHlu-0002r8-QX for guile-devel@m.gmane-mx.org; Sun, 12 Sep 2021 01:11:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPHlH-0002qv-5T for guile-devel@gnu.org; Sun, 12 Sep 2021 01:10:39 -0400 Original-Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:36549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPHlF-0002ql-Fl for guile-devel@gnu.org; Sun, 12 Sep 2021 01:10:38 -0400 Original-Received: by mail-pg1-x52d.google.com with SMTP id t1so6071234pgv.3 for ; Sat, 11 Sep 2021 22:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MFGfQ16f7QMd1+R7X8xeTNN8v9mq0HmAuT0ZZM+jcBg=; b=EhYEqgPJ0UyimRsHoW/mtFHWCJf+62jUQiAHpsffUMKxi9QjfQFPchg/VHeOTAKZ0X p+GwXWNAStdXrv1uICbfmBK9LU/k1ZEBqYFuNCY+JTZU7P439JRirAhiXB55k3acwYUl 6r8qetbJv+1pUZQptgpm4SJZfj+lXbh7kzh0k9EUFaJaUm4fya0Eh5glyS8dZifDW+Z4 v6sLjqgONXkLvrC5dcGKxNVXMoO7KzCL8kvm09cpswyjKaXEgTWtqFBVXgLtezpudL8v dN3DPPUZszz65cSd++bfJ+PXmho8d225v1lQi+Fln15455c8AjXHUaLPCgr4r7gzp66D uZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MFGfQ16f7QMd1+R7X8xeTNN8v9mq0HmAuT0ZZM+jcBg=; b=Si9wymUbra+/C4SJJR0OwXADkCOJj49BT7yRiGS8jJxLwolZdDzXWhx4cNU8/YW0SK RWG4X9Ln2gEDPGTsWXHMDx1cTpaaRmkwEnGzgPk8VqXTdtQFzYgUKbeg0vzd5VC9bC1E xXzFTh8dwFphm6mdgcdK2T4whhLGU7yc1ELHnEjsySjZPk2ImEJwlJBuY7j5QA8JXgT5 caut7OIbssya5wRqq7GTThWzNeWHvZ7EWU3MvlLsQCc88pCFwqJuliA0Zb/+5e1lfrlA DLwqrnKbcUq+cnV1Sb7m4hVvrjvfzHK2b502vSikTma/K+l8gfiUhbkY3jN5Rwjo4mJp bBrQ== X-Gm-Message-State: AOAM531U4pODXGaURl2Vi2jpj1ayg/ehZ08snWVsQGxHvQOdt2TwRV3q DSbSKfFI2LIsozVb70yUp2BARTnBnQg= X-Google-Smtp-Source: ABdhPJxmy1oCOamhvsrrKXVtxIVaGHba63sMv0wWVzunrvBIgfYP2OagWvETRxW98TKtWs1xzA7NGA== X-Received: by 2002:a63:b147:: with SMTP id g7mr5315968pgp.478.1631423435064; Sat, 11 Sep 2021 22:10:35 -0700 (PDT) Original-Received: from localhost (cpe-198-72-134-0.socal.res.rr.com. [198.72.134.0]) by smtp.gmail.com with ESMTPSA id d10sm3138437pfq.205.2021.09.11.22.10.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Sep 2021 22:10:34 -0700 (PDT) X-Mailer: git-send-email 2.33.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=aconchillo@gmail.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20856 Archived-At: * module/system/foreign-library.scm (load-foreign-library): On macOS calling `dlopen` with RTLD_LAZY | RTLD_LOCAL causes a crash when calling `dlsym`. There are a three working combinations: - Using RTLD_NOW | RTLD_LOCAL - Using RTLD_NOW | RTLD_GLOBAL - Using RTLD_LAZY | RTLD_GLOBAL For efficiency purposes we choose RTLD_LAZY | RTLD_GLOBAL. See https://lists.gnu.org/archive/html/guile-devel/2021-09/msg00008.html --- module/system/foreign-library.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/module/system/foreign-library.scm b/module/system/foreign-library.scm index dc426385f..63889277c 100644 --- a/module/system/foreign-library.scm +++ b/module/system/foreign-library.scm @@ -172,6 +172,11 @@ name." (else name))))) +;; In macOS using dlopen with RTLD_LAZY | RTLD_LOCAL produces a crash. +;; https://lists.gnu.org/archive/html/guile-devel/2021-09/msg00008.html +(define system-needs-global? + (string-contains %host-type "-darwin")) + (define* (load-foreign-library #:optional filename #:key (extensions system-library-extensions) (search-ltdl-library-path? #t) @@ -186,7 +191,7 @@ name." #f)) (define flags (logior (if lazy? RTLD_LAZY RTLD_NOW) - (if global? RTLD_GLOBAL RTLD_LOCAL))) + (if (or global? system-needs-global?) RTLD_GLOBAL RTLD_LOCAL))) (define (dlopen* name) (dlopen name flags)) (if (and rename-on-cygwin? (string-contains %host-type "cygwin")) (set! filename (lib->cyg filename))) -- 2.33.0