From: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
To: guile-devel@gnu.org
Cc: "Aleix Conchillo Flaqué" <aconchillo@gmail.com>
Subject: [PATCH] srfi-64: fix unused variable warnings
Date: Wed, 31 Mar 2021 23:11:35 -0700 [thread overview]
Message-ID: <20210401061135.11914-1-aconchillo@gmail.com> (raw)
* module/srfi/srfi-64/testing.scm: remove unused name variable and use
let instead of let*.
Signed-off-by: Aleix Conchillo Flaqué <aconchillo@gmail.com>
---
module/srfi/srfi-64/testing.scm | 32 +++++++++++++-------------------
1 file changed, 13 insertions(+), 19 deletions(-)
diff --git a/module/srfi/srfi-64/testing.scm b/module/srfi/srfi-64/testing.scm
index 37792cd0f..d97797786 100644
--- a/module/srfi/srfi-64/testing.scm
+++ b/module/srfi/srfi-64/testing.scm
@@ -707,26 +707,24 @@
(syntax-case (list x (list (syntax quote) (%test-source-line2 x))) ()
(((mac tname expr) line)
(syntax
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r (cons (cons 'test-name tname) line))
(%test-comp1body r expr))))
(((mac expr) line)
(syntax
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r line)
(%test-comp1body r expr)))))))
(define (%test-comp2 comp x)
(syntax-case (list x (list (syntax quote) (%test-source-line2 x)) comp) ()
(((mac tname expected expr) line comp)
(syntax
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r (cons (cons 'test-name tname) line))
(%test-comp2body r comp expected expr))))
(((mac expected expr) line comp)
(syntax
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r line)
(%test-comp2body r comp expected expr))))))
(define-syntax test-eqv
@@ -740,13 +738,12 @@
(syntax-case (list x (list (syntax quote) (%test-source-line2 x))) ()
(((mac tname expected expr error) line)
(syntax
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r (cons (cons 'test-name tname) line))
(%test-comp2body r (%test-approximate= error) expected expr))))
(((mac expected expr error) line)
(syntax
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r line)
(%test-comp2body r (%test-approximate= error) expected expr))))))))
(else
@@ -759,23 +756,21 @@
(define-syntax test-assert
(syntax-rules ()
((test-assert tname test-expression)
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r '((test-name . tname)))
(%test-comp1body r test-expression)))
((test-assert test-expression)
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r '())
(%test-comp1body r test-expression)))))
(define-syntax %test-comp2
(syntax-rules ()
((%test-comp2 comp tname expected expr)
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r (list (cons 'test-name tname)))
(%test-comp2body r comp expected expr)))
((%test-comp2 comp expected expr)
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r '())
(%test-comp2body r comp expected expr)))))
(define-syntax test-equal
@@ -895,18 +890,17 @@
(syntax-case (list x (list (syntax quote) (%test-source-line2 x))) ()
(((mac tname etype expr) line)
(syntax
- (let* ((r (test-runner-get))
- (name tname))
+ (let ((r (test-runner-get)))
(test-result-alist! r (cons (cons 'test-name tname) line))
(%test-error r etype expr))))
(((mac etype expr) line)
(syntax
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r line)
(%test-error r etype expr))))
(((mac expr) line)
(syntax
- (let* ((r (test-runner-get)))
+ (let ((r (test-runner-get)))
(test-result-alist! r line)
(%test-error r #t expr))))))))
(else
--
2.31.1
next reply other threads:[~2021-04-01 6:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 6:11 Aleix Conchillo Flaqué [this message]
2021-04-01 11:37 ` [PATCH] srfi-64: fix unused variable warnings Maxime Devos
2021-04-02 6:13 ` Aleix Conchillo Flaqué
[not found] ` <CA+XASoWMDakd2rAu96iZB-=giHLoer1gcM4dgu+wxg1MCZ9xDw@mail.gmail.com>
2021-04-02 6:58 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401061135.11914-1-aconchillo@gmail.com \
--to=aconchillo@gmail.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).