From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Gran Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH 1/1] Support mkdtemp via mkdtemp! and scm_mkdtemp Date: Mon, 11 Jan 2021 06:04:14 -0800 Message-ID: <20210111140353.GA1546612@spikycactus.com> References: <20201230015005.335417-1-rlb@defaultvalue.org> <20201230084122.GA824833@spikycactus.com> <87pn2q28ue.fsf@trouble.defaultvalue.org> <875z4ctdsw.fsf@trouble.defaultvalue.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8118"; mail-complaints-to="usenet@ciao.gmane.io" Cc: guile-devel@gnu.org To: Rob Browning Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Mon Jan 11 15:04:57 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyxoX-000203-Aq for guile-devel@m.gmane-mx.org; Mon, 11 Jan 2021 15:04:57 +0100 Original-Received: from localhost ([::1]:44676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyxoW-00084U-CL for guile-devel@m.gmane-mx.org; Mon, 11 Jan 2021 09:04:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyxo9-00083j-8k for guile-devel@gnu.org; Mon, 11 Jan 2021 09:04:34 -0500 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]:40503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyxo6-0002Be-T7 for guile-devel@gnu.org; Mon, 11 Jan 2021 09:04:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610373867; bh=PPqNPjbCnX622PEFKChIQsptg+CtuBdT8/Ys/yDiI0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=mdibNWcPsVi1vGwAdtEemPW6KT+D7+2THx+4iZEA2w6xV/fVXbmSNYTlbWv6NMjBRrwq6POssuNevj4whN0nTILhyp+COA4eNUsHGuWY7Kz3Z5+vdapfuFBra9IHX5OSC1KxaUwBHS+F0md1E+e4NK6gXVini4g4Gwo8PGNjc8PopBqo2aF/vozYUFZMntoAY6Dn1ObtY+rdmiswIZjL/fmWAr1/UIOZAlNCWVmzxFquKtCohjVoGEPbzjveND+7s9Vq/diERXBAKk3e1JhgPvbJMgUeDRpQY+Fl+KpQ3MNxC/J1Kfnw+7DU3w+PAduSQSQ4R80BbaSci5DYN7qkaQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610373867; bh=YJVB9I5mqQG8EoMco9TiNtsEyaOuqRUOI7ZlXYhTXf/=; h=Date:From:To:Subject:From:Subject; b=o1JqizD8Q0E6Pk1yhG7ksLdJUGykaUi8NfdVzVwn9l15AFczxP7+34tazlkWsrVL3X8s9KU3kNYrPuAr+1DPQ36jq6Z7cJloYvHjrobkSCCkTDBWWrQ9vhuvEh8If2ZBIGk9Xvwas8mi8kfw5hFArF7EUELa74hOs/n+Br1+MESx8aNfywgSoVsb63X/FkcBBBztGjWWEVOSqUJ2h7oiZewWr5sdBFHUbVpC2pThrypFC5UjeWJH+VMrfgVeszAv1j75QfzDDF+dWSJW7gxMX64gj/d7vBxIeWpkkSnoOsiLU0NJ4dOFiM9qnnDrzzBxvkUusPs9plg2Cx5/AYBo5Q== X-YMail-OSG: e.FGt4sVM1kOZPO6V6BMbQNRlwPtisYn8yfuU9keknUu43E9A8QUY5mi2eANapQ PWQicgh6t2ae.x72AbxRCvlbRQdCDikSO8fPfBFx_PIwApmZRtRCnwc6ScHtXv34hmYf4oqVcxuu AQIPKW1zE6Rdb.VZ1RmVdU7jyvF908UWWCIxv0m6Rffo2ocexbw88BCBvdCAJqASRSyQp3szT.fJ 360HPsuodOFgzHoh8Itn0H32ebIUHjXDlhnFxVxXJNWlCEhQmc17ir_XgudqnRd93ShPRWW_TZUa TNLxb88rLs9FQszpmESpQ4cgRS8UfusZG1GglAwlkBOpuLwzfVmpZU.ItQJQAl_XIDoNSvV6ETz7 lW5LyaZ6amMPwyb6nrCW3AzxratQvLdv2ck0e_CvXF97O99VoGxUqg4tsssK9hy9EhRu9AxoYrS9 UgKsDvReqvMmcn53tzvfgJIcHfg2qGH6dwkLXVLEfMEfuZxG.hTmrS68I6rerX8DTv9eBUsEe_o1 SBJPdW5jlCKDUKv1QXzX3zkLGAirOrqctJv0hijS28aH1AnurfVigELBOva4m1CDOtcfft3Bvo0n 73X_3XoGvLs4_6z0unFohNXfbY2Ryikv1_6gS10vSRgY2HHqXBtbQXbScMcMEM_nLRjib7tQdVVS X8dFgfsRdfkfRDYclPIyUGI2jD9YenW0.JdLf9WjmVsdf6G64NZjbLrC7saoCDp.G5OSXfnxVe63 _lNNKjFaBwCSLZJs3tFQCCblgSyPc6t8BGIgz7PO_PvsQ7flWcL6woYa8j9spTMplIAOcUhyG9qZ OgE..p2gPSfSBYX6k0wNwf4n_KLcOc1RYQh7_dJlHK Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jan 2021 14:04:27 +0000 Original-Received: by smtp402.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 6792521cf072f24c0ff28ec2932e9ef7; Mon, 11 Jan 2021 14:04:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <875z4ctdsw.fsf@trouble.defaultvalue.org> X-Mailer: WebService/1.1.17501 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=66.163.185.31; envelope-from=spk121@yahoo.com; helo=sonic313-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20634 Archived-At: On Mon, Jan 04, 2021 at 06:42:07PM -0600, Rob Browning wrote: > Rob Browning writes: > > > Mike Gran writes: > > > >> Since mkdtemp already returns a string of the new directory name, > >> it might be more scheme-like to not modify the input string, and instead > >> just return the new directory name. > > > > Perhaps, though I was just matching the existing semantics of guile > > mkstemp, i.e. figured maybe they should behave the same. > > ...mkstemp! I meant, and I think I might still somewhat favor keeping > the correspondence between a mkstemp! and mkdtemp! that have the same > semantics, and more or less directly match their POSIX functions. OK, fair enough. I'll push a patch on mkdtemp! in a day or two if you're good with the idea. (I asked on IRC.) But, one thing I'd like to change, if you don't mind, is the split into scm_i_mkdtemp and scm_mkdtemp because there is no internal client of scm_i_mkdtemp. Regards, Mike Gran