unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: David Pirotte <david@altosw.be>
To: lloda <lloda@sarc.name>
Cc: Andy Wingo <wingo@pobox.com>, guile-devel <guile-devel@gnu.org>
Subject: Re: [PATCH] Add string-replace-substring to (ice-9 string-fun)
Date: Sun, 5 Jan 2020 20:40:56 -0300	[thread overview]
Message-ID: <20200105204056.38b3b460@capac> (raw)
In-Reply-To: <06A75D0F-6B33-4363-8226-0ABE539E9079@sarc.name>

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

Hi,

> > On 5 Jan 2020, at 13:12, Jan Nieuwenhuizen <janneke@gnu.org> wrote:
> > 
> > Andy Wingo writes:
> >   
> >> On Fri 20 Dec 2019 18:32, lloda <lloda@sarc.name> writes:
> >>   
> >>> This patch adds string-replace-substring that wingo posted to the
> >>> mailing list to (ice-9 strings). This is a commonly used function
> >>> and a good implementation isn't trivial, so I think it deserves
> >>> inclusion.  
> >> 
> >> I didn't know that this module existed :)  Sure, why not.  Please
> >> fix the commit message when you push.  
> > 
> > That's great!  This is one of the things that has always amazed and
> > annoyed me to be missing and I have written several half-baken
> > implementations of it when I needed something like it.
> > 
> > Would it be too much to ask for some documentation to go with it, so
> > that we will be able to find it?  
> 
> Sure, I'll include that in the fixed patch.

Fwiw, guix has a (different) implementation as well, I don't know which
is best, but I think it should be anmed string-replace-all

	http://git.savannah.gnu.org/cgit/guix.git/tree/guix/utils.scm

David.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-01-05 23:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 17:32 [PATCH] Add string-replace-substring to (ice-9 string-fun) lloda
2020-01-05 11:34 ` Andy Wingo
2020-01-05 12:12   ` Jan Nieuwenhuizen
2020-01-05 13:51     ` Christopher Lam
2020-01-05 15:49       ` Arne Babenhauserheide
2020-01-05 14:01     ` lloda
2020-01-05 23:40       ` David Pirotte [this message]
2020-01-06  9:08 ` Linus Björnstam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200105204056.38b3b460@capac \
    --to=david@altosw.be \
    --cc=guile-devel@gnu.org \
    --cc=lloda@sarc.name \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).