unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: David Pirotte <david@altosw.be>
To: Andy Wingo <wingo@pobox.com>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: Master - Do not track html, tmp and some test-suite files
Date: Sat, 25 Jun 2016 17:51:33 -0300	[thread overview]
Message-ID: <20160625175133.6c4502b9@capac> (raw)
In-Reply-To: <87inwxbo6x.fsf@pobox.com>


[-- Attachment #1.1: Type: text/plain, Size: 924 bytes --]

Hello Andy,

> > Note that make check leaves the following toplevel file [a symlink to itself]
> > behind:
> >
> > 	filesys-test-link.tmp  

> I have seen this and I don't know why this is, and I would prefer to fix
> it rather than ignoring it.

Ok, as I said I did not look at the test-suite source code, and I'm afraid I won't
have time to do so, just to let you know.

> >  config.log
> >  config.h
> >  *.doc
> > +*.html  

> doc/ref/guile.html please

Fine, let's apply the patch I sent for stable-2.0 when you're happy then.

> > @@ -142,6 +144,7 @@ INSTALL
> >  /test-suite/standalone/test-scm-spawn-thread
> >  /test-suite/standalone/test-pthread-create
> >  /test-suite/standalone/test-pthread-create-secondary
> > +/test-suite/standalone/test-smob-mark-race
> >  /lib/fcntl.h  

> Good catch!
> So just a couple of nits, then please resend.  Thanks :)

Attached

Cheers,
David

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0002-Do-not-track-some-test-suite-files.patch --]
[-- Type: text/x-patch, Size: 757 bytes --]

From 45795a5d90de5e87b452d32189a9b5b1eb410ae5 Mon Sep 17 00:00:00 2001
From: David Pirotte <david@altosw.be>
Date: Sat, 25 Jun 2016 17:42:09 -0300
Subject: [PATCH 2/2] Do not track some test-suite files

* .gitignore:  Adding test-smob-mark-race to the list of the test-suite
  files we do not track.
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 6375f2b..7f9d630 100644
--- a/.gitignore
+++ b/.gitignore
@@ -142,6 +142,7 @@ INSTALL
 /test-suite/standalone/test-scm-spawn-thread
 /test-suite/standalone/test-pthread-create
 /test-suite/standalone/test-pthread-create-secondary
+/test-suite/standalone/test-smob-mark-race
 /lib/fcntl.h
 /lib/sys/uio.h
 /lib/stdalign.h
-- 
2.8.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-06-25 20:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25  2:40 Master - Do not track html, tmp and some test-suite files David Pirotte
2016-06-25  9:41 ` Andy Wingo
2016-06-25 20:51   ` David Pirotte [this message]
2016-06-27  7:36     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160625175133.6c4502b9@capac \
    --to=david@altosw.be \
    --cc=guile-devel@gnu.org \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).