Master - Do not track html, tmp and some test-suite files

Master - Do not track html, tmp and some test-suite files

[David Pirotte]

[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

Hello,

	Attached...

Note that make check leaves the following toplevel file [a symlink to itself] behind:

	filesys-test-link.tmp

I guess make check itself should be patched but I don't know how.

David

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0002-Do-not-track-html-tmp-and-some-test-suite-files.patch --]
[-- Type: text/x-patch, Size: 888 bytes --]

From 8a0878a17a5f2ff7a74ec636ef646916adf51975 Mon Sep 17 00:00:00 2001
From: David Pirotte <david@altosw.be>
Date: Fri, 24 Jun 2016 23:31:49 -0300
Subject: [PATCH 2/2] Do not track html, tmp and some test-suite files

* .gitignore:  Do not track html files and dirs, *.tmp files and
  test-suite/standalone/test-smob-mark-race
---
 .gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 6375f2b..44e18dc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,6 +13,8 @@ config.status
 config.log
 config.h
 *.doc
+*.html
+*.tmp
 *.x
 *.lo
 *.la
@@ -142,6 +144,7 @@ INSTALL
 /test-suite/standalone/test-scm-spawn-thread
 /test-suite/standalone/test-pthread-create
 /test-suite/standalone/test-pthread-create-secondary
+/test-suite/standalone/test-smob-mark-race
 /lib/fcntl.h
 /lib/sys/uio.h
 /lib/stdalign.h
-- 
2.8.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: Master - Do not track html, tmp and some test-suite files

[Andy Wingo]

On Sat 25 Jun 2016 04:40, David Pirotte <david@altosw.be> writes:

> Note that make check leaves the following toplevel file [a symlink to itself] behind:
>
> 	filesys-test-link.tmp

I have seen this and I don't know why this is, and I would prefer to fix
it rather than ignoring it.

>  config.log
>  config.h
>  *.doc
> +*.html

doc/ref/guile.html please

> @@ -142,6 +144,7 @@ INSTALL
>  /test-suite/standalone/test-scm-spawn-thread
>  /test-suite/standalone/test-pthread-create
>  /test-suite/standalone/test-pthread-create-secondary
> +/test-suite/standalone/test-smob-mark-race
>  /lib/fcntl.h

Good catch!

So just a couple of nits, then please resend.  Thanks :)

Andy

Re: Master - Do not track html, tmp and some test-suite files

[David Pirotte]

[-- Attachment #1.1: Type: text/plain, Size: 924 bytes --]

Hello Andy,

> > Note that make check leaves the following toplevel file [a symlink to itself]
> > behind:
> >
> > 	filesys-test-link.tmp  

> I have seen this and I don't know why this is, and I would prefer to fix
> it rather than ignoring it.

Ok, as I said I did not look at the test-suite source code, and I'm afraid I won't
have time to do so, just to let you know.

> >  config.log
> >  config.h
> >  *.doc
> > +*.html  

> doc/ref/guile.html please

Fine, let's apply the patch I sent for stable-2.0 when you're happy then.

> > @@ -142,6 +144,7 @@ INSTALL
> >  /test-suite/standalone/test-scm-spawn-thread
> >  /test-suite/standalone/test-pthread-create
> >  /test-suite/standalone/test-pthread-create-secondary
> > +/test-suite/standalone/test-smob-mark-race
> >  /lib/fcntl.h  

> Good catch!
> So just a couple of nits, then please resend.  Thanks :)

Attached

Cheers,
David

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0002-Do-not-track-some-test-suite-files.patch --]
[-- Type: text/x-patch, Size: 757 bytes --]

From 45795a5d90de5e87b452d32189a9b5b1eb410ae5 Mon Sep 17 00:00:00 2001
From: David Pirotte <david@altosw.be>
Date: Sat, 25 Jun 2016 17:42:09 -0300
Subject: [PATCH 2/2] Do not track some test-suite files

* .gitignore:  Adding test-smob-mark-race to the list of the test-suite
  files we do not track.
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 6375f2b..7f9d630 100644
--- a/.gitignore
+++ b/.gitignore
@@ -142,6 +142,7 @@ INSTALL
 /test-suite/standalone/test-scm-spawn-thread
 /test-suite/standalone/test-pthread-create
 /test-suite/standalone/test-pthread-create-secondary
+/test-suite/standalone/test-smob-mark-race
 /lib/fcntl.h
 /lib/sys/uio.h
 /lib/stdalign.h
-- 
2.8.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: Master - Do not track html, tmp and some test-suite files

[Andy Wingo]

On Sat 25 Jun 2016 22:51, David Pirotte <david@altosw.be> writes:

> From 45795a5d90de5e87b452d32189a9b5b1eb410ae5 Mon Sep 17 00:00:00 2001
> From: David Pirotte <david@altosw.be>
> Date: Sat, 25 Jun 2016 17:42:09 -0300
> Subject: [PATCH 2/2] Do not track some test-suite files
>
> * .gitignore:  Adding test-smob-mark-race to the list of the test-suite
>   files we do not track.

Applied to both branches, thanks :)

Andy