From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Fang Newsgroups: gmane.lisp.guile.devel Subject: Re: guile-1.8.6: libguile/inline.h nitpick Date: Thu, 5 Feb 2009 17:24:31 -0500 (EST) Message-ID: <20090205172159.S23109@shannon.csl.cornell.edu> References: <20090127190338.W71592@shannon.csl.cornell.edu> <87wsc4h6ne.fsf@arudy.ossau.uklinux.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Trace: ger.gmane.org 1233872705 3784 80.91.229.12 (5 Feb 2009 22:25:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2009 22:25:05 +0000 (UTC) Cc: guile-devel@gnu.org To: Neil Jerram Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Feb 05 23:26:19 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LVCfo-00016r-Uu for guile-devel@m.gmane.org; Thu, 05 Feb 2009 23:26:18 +0100 Original-Received: from localhost ([127.0.0.1]:43778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVCeV-0002wJ-FS for guile-devel@m.gmane.org; Thu, 05 Feb 2009 17:24:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVCeP-0002uB-5Q for guile-devel@gnu.org; Thu, 05 Feb 2009 17:24:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVCeL-0002sN-NF for guile-devel@gnu.org; Thu, 05 Feb 2009 17:24:48 -0500 Original-Received: from [199.232.76.173] (port=37835 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVCeL-0002sJ-CM for guile-devel@gnu.org; Thu, 05 Feb 2009 17:24:45 -0500 Original-Received: from csl.cornell.edu ([128.84.224.10]:4270 helo=vlsi.csl.cornell.edu) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVCeJ-0004h2-Vg for guile-devel@gnu.org; Thu, 05 Feb 2009 17:24:45 -0500 Original-Received: from shannon.csl.cornell.edu (shannon.csl.cornell.edu [128.84.224.88]) by vlsi.csl.cornell.edu (8.13.4/8.13.4) with ESMTP id n15MOVtT002446; Thu, 5 Feb 2009 17:24:36 -0500 (EST) Original-Received: from shannon.csl.cornell.edu (localhost.csl.cornell.edu [127.0.0.1]) by shannon.csl.cornell.edu (8.13.8/8.13.8) with ESMTP id n15MOVpJ023752; Thu, 5 Feb 2009 17:24:31 -0500 (EST) (envelope-from fang@shannon.csl.cornell.edu) Original-Received: from localhost (fang@localhost) by shannon.csl.cornell.edu (8.13.8/8.13.8/Submit) with ESMTP id n15MOVsQ023749; Thu, 5 Feb 2009 17:24:31 -0500 (EST) (envelope-from fang@shannon.csl.cornell.edu) In-Reply-To: <87wsc4h6ne.fsf@arudy.ossau.uklinux.net> X-detected-operating-system: by monty-python.gnu.org: FreeBSD 2.0-4.2 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8138 Archived-At: >> Can we change line 57 from: >> to something like: >> >> # if (defined __GNUC__) && (!((defined __APPLE_CC__) && __APPLE_CC__ > >> 5400 && __STDC_VERSION__ >= 199901L >> >> which checks for __APPLE_CC__ defined before using it? > > Sure. Proposed patch for this is attached, please let me know if any > comments. Thanks, Neil! Patch looks good to me. Fang David Fang http://www.csl.cornell.edu/~fang/ http://www.achronix.com/