From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Fang Newsgroups: gmane.lisp.guile.devel Subject: guile-1.8.6: libguile/inline.h nitpick Date: Tue, 27 Jan 2009 19:22:13 -0500 (EST) Message-ID: <20090127190338.W71592@shannon.csl.cornell.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Trace: ger.gmane.org 1233102164 3386 80.91.229.12 (28 Jan 2009 00:22:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Jan 2009 00:22:44 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jan 28 01:23:57 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRyDi-0003Qk-3W for guile-devel@m.gmane.org; Wed, 28 Jan 2009 01:23:54 +0100 Original-Received: from localhost ([127.0.0.1]:52081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRyCQ-00024Q-17 for guile-devel@m.gmane.org; Tue, 27 Jan 2009 19:22:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRyCI-00023H-Rw for guile-devel@gnu.org; Tue, 27 Jan 2009 19:22:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRyCH-00022I-Fl for guile-devel@gnu.org; Tue, 27 Jan 2009 19:22:26 -0500 Original-Received: from [199.232.76.173] (port=39403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRyCH-00022D-DP for guile-devel@gnu.org; Tue, 27 Jan 2009 19:22:25 -0500 Original-Received: from csl.cornell.edu ([128.84.224.10]:1774 helo=vlsi.csl.cornell.edu) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRyCH-0007Fo-6A for guile-devel@gnu.org; Tue, 27 Jan 2009 19:22:25 -0500 Original-Received: from shannon.csl.cornell.edu (shannon.csl.cornell.edu [128.84.224.88]) by vlsi.csl.cornell.edu (8.13.4/8.13.4) with ESMTP id n0S0MECI069551 for ; Tue, 27 Jan 2009 19:22:19 -0500 (EST) Original-Received: from shannon.csl.cornell.edu (localhost.csl.cornell.edu [127.0.0.1]) by shannon.csl.cornell.edu (8.13.8/8.13.8) with ESMTP id n0S0MDwI072609 for ; Tue, 27 Jan 2009 19:22:13 -0500 (EST) (envelope-from fang@shannon.csl.cornell.edu) Original-Received: from localhost (fang@localhost) by shannon.csl.cornell.edu (8.13.8/8.13.8/Submit) with ESMTP id n0S0MD7V072606 for ; Tue, 27 Jan 2009 19:22:13 -0500 (EST) (envelope-from fang@shannon.csl.cornell.edu) X-detected-operating-system: by monty-python.gnu.org: FreeBSD 2.0-4.2 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8094 Archived-At: Hi all, Minor nit about the "libguile/inline.h" header: I typically compile with g++ ... -Wundef -Werror, which catches uses of undefined preprocessor tokens: /usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined In file included from /usr/local/include/libguile.h:114, /usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined __APPLE_CC__ is only defined for Apple, which is causing my compiles to fail (didn't used to fail with older guile.) Can we change line 57 from: # if (defined __GNUC__) && (!(__APPLE_CC__ > 5400 && __STDC_VERSION__ >= 199901L to something like: # if (defined __GNUC__) && (!((defined __APPLE_CC__) && __APPLE_CC__ > 5400 && __STDC_VERSION__ >= 199901L which checks for __APPLE_CC__ defined before using it? Thanks. Fang David Fang http://www.csl.cornell.edu/~fang/ http://www.achronix.com/