unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: David Fang <fang@csl.cornell.edu>
To: guile-devel@gnu.org
Subject: guile-1.8.6: libguile/inline.h nitpick
Date: Tue, 27 Jan 2009 19:22:13 -0500 (EST)	[thread overview]
Message-ID: <20090127190338.W71592@shannon.csl.cornell.edu> (raw)

Hi all,

Minor nit about the "libguile/inline.h" header:

I typically compile with g++ ... -Wundef -Werror, which catches uses of 
undefined preprocessor tokens:

/usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined
In file included from /usr/local/include/libguile.h:114,
/usr/local/include/libguile/inline.h:57:31: "__APPLE_CC__" is not defined

__APPLE_CC__ is only defined for Apple, which is causing my compiles to 
fail (didn't used to fail with older guile.)


Can we change line 57 from:

# if (defined __GNUC__) && (!(__APPLE_CC__ > 5400 && __STDC_VERSION__ >= 
199901L

to something like:

# if (defined __GNUC__) && (!((defined __APPLE_CC__) && __APPLE_CC__ > 
5400 && __STDC_VERSION__ >= 199901L

which checks for __APPLE_CC__ defined before using it?

Thanks.

Fang


David Fang
http://www.csl.cornell.edu/~fang/
http://www.achronix.com/





             reply	other threads:[~2009-01-28  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  0:22 David Fang [this message]
2009-02-05 22:15 ` guile-1.8.6: libguile/inline.h nitpick Neil Jerram
2009-02-05 22:24   ` David Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090127190338.W71592@shannon.csl.cornell.edu \
    --to=fang@csl.cornell.edu \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).