From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Miroslav Lichvar Newsgroups: gmane.lisp.guile.devel Subject: Re: `scm_c_read ()' and `swap_buffer' trick harmful Date: Fri, 19 Dec 2008 15:44:46 +0100 Message-ID: <20081219144446.GC20162@localhost> References: <87vduo92nj.fsf@gnu.org> <49dd78620811200522k315281c8m9d952a17145b2479@mail.gmail.com> <871vx6ik42.fsf@gnu.org> <49dd78620811201425j5dcd7e0g4165c8ea4c6b08ce@mail.gmail.com> <87fxllt3f7.fsf@gnu.org> <49dd78620811231430o5f0d6dc7u16c2fbf29b73c57c@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1229697915 28460 80.91.229.12 (19 Dec 2008 14:45:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2008 14:45:15 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Dec 19 15:46:20 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LDgcE-0001lw-5O for guile-devel@m.gmane.org; Fri, 19 Dec 2008 15:46:10 +0100 Original-Received: from localhost ([127.0.0.1]:57698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDgb2-0003kM-0z for guile-devel@m.gmane.org; Fri, 19 Dec 2008 09:44:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDgaw-0003kH-7l for guile-devel@gnu.org; Fri, 19 Dec 2008 09:44:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDgat-0003k5-QB for guile-devel@gnu.org; Fri, 19 Dec 2008 09:44:48 -0500 Original-Received: from [199.232.76.173] (port=33908 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDgat-0003k2-KN for guile-devel@gnu.org; Fri, 19 Dec 2008 09:44:47 -0500 Original-Received: from mx2.redhat.com ([66.187.237.31]:33739) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LDgat-000813-5J for guile-devel@gnu.org; Fri, 19 Dec 2008 09:44:47 -0500 Original-Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBJEijmO023768 for ; Fri, 19 Dec 2008 09:44:45 -0500 Original-Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBJEihSq006437 for ; Fri, 19 Dec 2008 09:44:45 -0500 Original-Received: from localhost (dhcp-lab-101.englab.brq.redhat.com [10.34.33.101]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mBJEifig029966 for ; Fri, 19 Dec 2008 09:44:42 -0500 Content-Disposition: inline In-Reply-To: <49dd78620811231430o5f0d6dc7u16c2fbf29b73c57c@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-11-24) X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-MIME-Autoconverted: from 8bit to quoted-printable by mx2.redhat.com id mBJEijmO023768 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7935 Archived-At: On Sun, Nov 23, 2008 at 10:30:19PM +0000, Neil Jerram wrote: > 2008/11/21 Ludovic Court=E8s : > > I confirm it works with CBIPs in Guile-R6RS-Libs, but I had to make t= his > > small change: > > > > http://repo.or.cz/w/guile-r6rs-libs.git?a=3Dcommitdiff;h=3Ddfab2fe21= f82bc40cfdf9a3a3eeb6936d5935c8c > > > > IOW, with Guile up to 1.8.5, it was harmless to leave `read_buf_size' > > uninitialized (actually, zeroed), which was OK since CBIPs don't use = it, > > but the change in `scm_c_read ()' makes it necessary to initialize it. > > It's probably a reasonable expectation, though. >=20 > Hmm. I agree that this isn't ideal. I guess it's OK for now though. >=20 > > Please commit! >=20 > Thanks, doing that now. It seems that the optimizations broke lilypond, it's now failing with this message: ports.c:978: scm_fill_input: Assertion `pt->read_pos =3D=3D pt->read_end'= failed. A bug report is here: https://bugzilla.redhat.com/show_bug.cgi?id=3D477007 Reverting bed2e15f and 1d17348b fixes the problem, is this a lilypond or guile bug? Thanks, --=20 Miroslav Lichvar