From: Miroslav Lichvar <mlichvar@redhat.com>
To: guile-devel@gnu.org
Subject: Re: `scm_c_read ()' and `swap_buffer' trick harmful
Date: Fri, 19 Dec 2008 15:44:46 +0100 [thread overview]
Message-ID: <20081219144446.GC20162@localhost> (raw)
In-Reply-To: <49dd78620811231430o5f0d6dc7u16c2fbf29b73c57c@mail.gmail.com>
On Sun, Nov 23, 2008 at 10:30:19PM +0000, Neil Jerram wrote:
> 2008/11/21 Ludovic Courtès <ludo@gnu.org>:
> > I confirm it works with CBIPs in Guile-R6RS-Libs, but I had to make this
> > small change:
> >
> > http://repo.or.cz/w/guile-r6rs-libs.git?a=commitdiff;h=dfab2fe21f82bc40cfdf9a3a3eeb6936d5935c8c
> >
> > IOW, with Guile up to 1.8.5, it was harmless to leave `read_buf_size'
> > uninitialized (actually, zeroed), which was OK since CBIPs don't use it,
> > but the change in `scm_c_read ()' makes it necessary to initialize it.
> > It's probably a reasonable expectation, though.
>
> Hmm. I agree that this isn't ideal. I guess it's OK for now though.
>
> > Please commit!
>
> Thanks, doing that now.
It seems that the optimizations broke lilypond, it's now failing with
this message:
ports.c:978: scm_fill_input: Assertion `pt->read_pos == pt->read_end' failed.
A bug report is here:
https://bugzilla.redhat.com/show_bug.cgi?id=477007
Reverting bed2e15f and 1d17348b fixes the problem, is this a lilypond
or guile bug?
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2008-12-19 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 20:04 `scm_c_read ()' and `swap_buffer' trick harmful Ludovic Courtès
2008-11-20 13:22 ` Neil Jerram
2008-11-20 13:48 ` Ludovic Courtès
2008-11-20 22:25 ` Neil Jerram
2008-11-21 17:05 ` Ludovic Courtès
2008-11-22 15:02 ` Ludovic Courtès
2008-11-23 23:08 ` Neil Jerram
2008-11-23 22:30 ` Neil Jerram
2008-12-19 14:44 ` Miroslav Lichvar [this message]
2008-12-19 20:25 ` Ludovic Courtès
2008-12-19 23:32 ` Miroslav Lichvar
2008-12-20 17:10 ` Ludovic Courtès
2008-12-20 19:11 ` Miroslav Lichvar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081219144446.GC20162@localhost \
--to=mlichvar@redhat.com \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).