unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: guile 1.8 and x86_64
Date: Fri, 5 May 2006 16:05:34 +0200	[thread overview]
Message-ID: <20060505140534.GA13293@bordell.redhat.usu> (raw)
In-Reply-To: <87zmirvoew.fsf@ossau.uklinux.net>

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi,

attached is a patch that seems to fix the problem with gcc4 and 64bit
architectures.

The scm_mark_locations function in gc-mark.c calls scm_gc_mark on
everything located in one of the allocated segments. Shouldn't there
be a check if the address is at least scm_t_cell aligned? 

Is it correct or is it just plain luck it works with the patch?

Thanks,

-- 
Miroslav Lichvar

[-- Attachment #2: gcmark.patch --]
[-- Type: text/plain, Size: 407 bytes --]

--- libguile/gc-mark.c.orig	2006-02-12 14:29:12.000000000 +0100
+++ libguile/gc-mark.c	2006-05-05 14:41:07.000000000 +0200
@@ -433,6 +433,8 @@
   for (m = 0; m < n; ++m)
     {
       SCM obj = * (SCM *) &x[m];
+      if ((scm_t_bits)obj & (sizeof (scm_t_cell) - 1))
+        continue;
       long int segment = scm_i_find_heap_segment_containing_object (obj);
       if (segment >= 0)
 	scm_gc_mark (obj);

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

  parent reply	other threads:[~2006-05-05 14:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-07 19:40 guile 1.8 and x86_64 Quanah Gibson-Mount
2006-04-10  8:14 ` Ludovic Courtès
2006-04-10 22:55   ` Neil Jerram
2006-04-10 23:03     ` Quanah Gibson-Mount
2006-04-11 20:37       ` Neil Jerram
2006-04-11 20:52         ` Quanah Gibson-Mount
2006-05-05 14:05         ` Miroslav Lichvar [this message]
2006-05-06 11:12           ` Miroslav Lichvar
2006-05-07 21:29             ` Marius Vollmer
2006-05-08 10:28               ` Andy Wingo
2006-05-08 21:52                 ` Marius Vollmer
2006-05-09  6:49                   ` Neil Jerram
2006-05-09 13:23                     ` Andy Wingo
2006-05-09 22:31                       ` Default stack limit Marius Vollmer
2006-05-10 14:31                         ` Andy Wingo
2006-05-10 23:58                           ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060505140534.GA13293@bordell.redhat.usu \
    --to=mlichvar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).