From: Mike Gran <spk121@yahoo.com>
To: "Juhani Viheräkoski" <moonshine@kapsi.fi>,
guile-devel <guile-devel@gnu.org>
Subject: Re: i guess we're frozen & stuff
Date: Tue, 11 Aug 2009 11:01:39 -0700 (PDT) [thread overview]
Message-ID: <170035.80458.qm@web37902.mail.mud.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0908112034000.16144@lakka.kapsi>
> From: Juhani Viheräkoski moonshine@kapsi.fi
> Hi,
>
> For me the build of the current master fails with:
>
> libtool: compile: gcc -DHAVE_CONFIG_H -DBUILDING_LIBGUILE=1 -I.. -I..
-I../lib
> -I../lib -pthread -Wall -Wmissing-prototypes -Werror -fvisibility=hidden -O3
-g
> -march=athlon-xp -MT libguile_la-strings.lo -MD -MP -MF
> .deps/libguile_la-strings.Tpo -c strings.c -fPIC -DPIC -o
> .libs/libguile_la-strings.o
> cc1: warnings being treated as errors
> strings.c: In function ‘scm_string_append’:
> strings.c:1300: error: ‘data’ may be used uninitialized in this function
> make[3]: *** [libguile_la-strings.lo] Error 1
>
> It is easy to disable -Werror or set the offending variable to NULL, but with
my
> limited knowledge of Guile internals it seems that this uninitialized pointer
is
> indeed passed to scm_i_make_string or scm_i_make_wide_string which do not seem
> to reserve space for it and even dereference the pointer. Might be just me,
but
> it seems there is something weird going on here..
>
This one's okay, I think. The allocation is made in make_stringbuf and `data'
is set to point to its buffer.
We'll have to set it to NULL in scm_string_append and other places to quiet
warnings.
> -- Juhani
Thanks,
-Mike
next prev parent reply other threads:[~2009-08-11 18:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 19:41 i guess we're frozen & stuff Andy Wingo
2009-08-10 21:08 ` Mike Gran
2009-08-10 21:16 ` Andy Wingo
2009-08-10 21:37 ` Ludovic Courtès
2009-08-11 11:34 ` Greg Troxel
2009-08-11 13:59 ` Ken Raeburn
2009-08-11 14:45 ` Ken Raeburn
2009-08-11 15:36 ` Ludovic Courtès
2009-08-11 15:50 ` Ken Raeburn
2009-08-12 22:42 ` Andy Wingo
2009-08-11 15:34 ` Ludovic Courtès
2009-08-12 22:41 ` Andy Wingo
2009-09-16 19:00 ` Andy Wingo
2009-09-25 21:59 ` Ken Raeburn
2009-09-26 15:45 ` Mike Gran
2009-09-26 22:36 ` Ken Raeburn
2009-09-26 23:11 ` Mike Gran
2009-09-26 21:02 ` Ludovic Courtès
2009-09-26 22:26 ` Ken Raeburn
2009-09-27 9:10 ` Ludovic Courtès
2009-09-27 10:01 ` Ken Raeburn
2009-09-28 7:39 ` Ludovic Courtès
2009-09-28 17:22 ` Neil Jerram
2009-09-28 18:48 ` Ludovic Courtès
2009-09-28 22:42 ` Neil Jerram
2009-09-28 23:21 ` Bug #27457 (“Threads, mutexes, and critical sections”) Ludovic Courtès
2009-09-30 20:59 ` (no subject) Neil Jerram
2009-10-01 17:21 ` Bug #27457 (“Threads, mutexes, and critical sections”) Ludovic Courtès
2009-10-01 21:05 ` (no subject) Neil Jerram
2009-10-01 19:45 ` Bug #27457 (“Threads, mutexes, and critical sections”) Ken Raeburn
2009-10-01 20:44 ` (no subject) Neil Jerram
2009-09-28 23:27 ` i guess we're frozen & stuff Ken Raeburn
2009-09-28 23:08 ` Ken Raeburn
2009-08-26 22:18 ` Neil Jerram
2009-08-11 12:29 ` Greg Troxel
2009-08-11 15:48 ` Mike Gran
2009-08-11 15:54 ` Ludovic Courtès
2009-08-11 16:13 ` Mike Gran
2009-08-11 17:01 ` Ludovic Courtès
2009-08-11 17:49 ` Mike Gran
2009-08-11 17:04 ` Greg Troxel
2009-08-11 18:14 ` Ken Raeburn
2009-08-11 20:34 ` Ludovic Courtès
2009-08-11 21:58 ` Greg Troxel
2009-08-11 22:46 ` Ludovic Courtès
2009-08-12 13:08 ` Greg Troxel
2009-08-12 14:38 ` Ludovic Courtès
2009-08-12 16:36 ` Greg Troxel
2009-08-11 18:15 ` Ludovic Courtès
2009-08-11 18:17 ` Greg Troxel
2009-08-11 20:26 ` Ludovic Courtès
2009-08-11 22:07 ` Greg Troxel
2009-08-11 17:24 ` Greg Troxel
2009-08-11 19:10 ` i18n issues on NetBSD Ludovic Courtès
2009-08-11 22:05 ` Greg Troxel
2009-08-11 22:58 ` Ludovic Courtès
2009-08-11 17:46 ` i guess we're frozen & stuff Juhani Viheräkoski
2009-08-11 18:01 ` Mike Gran [this message]
2009-08-11 20:31 ` Ludovic Courtès
2009-08-11 13:27 ` Greg Troxel
2009-08-11 13:39 ` unsigned char confusion Greg Troxel
2009-08-11 15:23 ` Mike Gran
2009-08-11 17:05 ` i guess we're frozen & stuff Ken Raeburn
2009-08-11 20:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170035.80458.qm@web37902.mail.mud.yahoo.com \
--to=spk121@yahoo.com \
--cc=guile-devel@gnu.org \
--cc=moonshine@kapsi.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).