unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Han-Wen Nienhuys <hanwen@cs.uu.nl>
Cc: guile-devel@gnu.org
Subject: gcc optimisation breaks guile floating point
Date: Wed, 28 Aug 2002 00:30:16 +0200	[thread overview]
Message-ID: <15723.64888.759743.439428@blauw.xs4all.nl> (raw)
In-Reply-To: <200208272110.OAA20247@onyx.he.net>

ghouston@arglist.com writes:
> 
> Apparently, "according to ANSI C" (no direct quotation available), the
> compiler can assume that *((unsigned long *) z) and *((double *) z)
> refer to different locations and reorder the statements!
> 
> I don't know what would be needed to make Guile conform to such
> stringent interpretation of the standard, but I don't think it would
> be easy to determine that it was correct and that it would always stay
> that way.  Perhaps we should just add the -fno-strict-aliasing option
> if the compiler supports it?

I think that these double (as in twice) initializations are weird, and
should go. Why not

    scm_t_double bla;
    bla.tag = scm_double_tag
    bla.pad = 0x0
    bla.double = z;
    return scm_double_cell (
        ((scm_t_double_cell*) &bla) -> car,
        ((scm_t_double_cell*) &bla) -> cbr,
        ((scm_t_double_cell*) &bla) -> ccr,
        ((scm_t_double_cell*) &bla) -> cdr);

If we use -fno-strict-aliasing (a kludge, IMO), we should double check
that all inline functions are correct , for clients might not compile
with -fno-strict-aliasing.

Another option

  *((unsigned long *) z) = 0;
  scm_remember ((SCM) z);
  *((double *) z) = x;
  return z;


-- 

Han-Wen Nienhuys   |   hanwen@cs.uu.nl   |   http://www.cs.uu.nl/~hanwen 


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2002-08-27 22:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-27 21:10 gcc optimisation breaks guile floating point Gary Houston
2002-08-27 22:30 ` Han-Wen Nienhuys [this message]
2002-08-28 20:26   ` Marius Vollmer
2002-08-28 22:53     ` Han-Wen Nienhuys
2002-08-30 17:44       ` Gary Houston
2002-09-05 21:10         ` Han-Wen Nienhuys
2002-09-12  1:46           ` Carl R. Witty
2002-09-13 21:20             ` Han-Wen Nienhuys
2002-09-24 22:32             ` Gary Houston
     [not found]             ` <200209242233.PAA04201@onyx.he.net>
2002-10-02 22:40               ` Marius Vollmer
2002-10-02 23:34                 ` Gary Houston
     [not found]                 ` <200210022336.QAA18265@onyx.he.net>
2002-10-03 12:33                   ` Marius Vollmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15723.64888.759743.439428@blauw.xs4all.nl \
    --to=hanwen@cs.uu.nl \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).