From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Han-Wen Nienhuys Newsgroups: gmane.lisp.guile.devel Subject: Re: GC rewrite, first version. Date: Wed, 31 Jul 2002 20:02:46 +0200 Sender: guile-devel-admin@gnu.org Message-ID: <15688.9798.978583.867042@meddo.cs.uu.nl> References: <15685.48166.358219.226421@blauw.xs4all.nl> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1028138838 5538 127.0.0.1 (31 Jul 2002 18:07:18 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 31 Jul 2002 18:07:18 +0000 (UTC) Cc: guile-devel@gnu.org Return-path: Original-Received: from fencepost.gnu.org ([199.232.76.164]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17ZxsS-0001RD-00 for ; Wed, 31 Jul 2002 20:07:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17Zxsr-0006tw-00; Wed, 31 Jul 2002 14:07:41 -0400 Original-Received: from aurora.cs.uu.nl ([131.211.80.20] helo=mail.cs.uu.nl) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17Zxo8-00069l-00 for ; Wed, 31 Jul 2002 14:02:48 -0400 Original-Received: from meddo.cs.uu.nl.cs.uu.nl (meddo.cs.uu.nl [131.211.80.91]) by mail.cs.uu.nl (Postfix) with ESMTP id 1056A1CB311; Wed, 31 Jul 2002 20:02:47 +0200 (CEST) Original-To: Dirk Herrmann In-Reply-To: X-Mailer: VM 7.03 under Emacs 21.2.1 Errors-To: guile-devel-admin@gnu.org X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.lisp.guile.devel:901 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:901 dirk@sallust.ida.ing.tu-bs.de writes: > However, when you are going to add your stuff to CVS I think it is > important that it does not deliberately violate conventions that have been > agreed upon. Feel free to start a discussion about improving the > convention, but until the decision is made to change things the way you > like it, please follow the current convention when changing code in CVS. I'm a bit reluctant to start a discussion, because that typically draws comments from people that don't code, but do think they know better anyway. With this warning in advance, comments from people that write actual Scheme code is welcome. Personally, I view source code as a form of prose. It should be easily readable. Hence I prefer variable names that can just be read as an english expression, with the prefix scm_ for delimiting our namespace, perhaps with an abbreviation here or there to keep the lines within my editor window. Typically, the most generic word (always a noun), eg number, size, string, comes last i.e. scm_heap_segment_table_size scm_formals_str(ing) in stead of scm_n_heap_segs scm_s_formals Inside C structs this convention is kept reasonably well, i.e. throw_value jmpbuf backing_store_size line_number rstate_size However, all exported symbols that don't have a Scheme-derived name are named with unpronounceable and unreadable names. I would prefer the following: internal ENTITY_X: internal_ENTITY_X (not i_ENTITY_X) string FOO: FOO_string (not s_foo) BAR-type: Bar_type (not t_BAR) (or even: simply BAR. Constructors are named new_BAR, so no clashes should arise) number of FOOS: FOO_count Perhaps the other way (generic word first) would also be readable, but then most of the C code is wrong. To what extent are these naming standards decided (names.txt is dated march, and I believe little has been done on the code since)? If it is we have to wait for two releases (four years) before the old names are scrapped, then I'm not going to waste energy on it. And for the rest, I think that GUILE 1.6 should be released. As an aside, if no-one objects to it, I would like to merge the new GC code coming weekend. -- Han-Wen Nienhuys | hanwen@cs.uu.nl | http://www.cs.uu.nl/~hanwen/ _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel