* [PATCH 1/1] Add "&" asm constraint modifier to ASM_MUL outputs
@ 2014-09-19 22:42 Rob Browning
2014-09-22 3:39 ` Mark H Weaver
0 siblings, 1 reply; 2+ messages in thread
From: Rob Browning @ 2014-09-19 22:42 UTC (permalink / raw)
To: guile-devel
Without this change, building for arm{hf,el} with gcc-4.9 (Debian
4.9.1-14) fails as follows:
/tmp/ccdZTkXQ.s:14591: rdhi, rdlo and rm must all be different
Thanks to Mark H Weaver <mhw@netris.org> for the suggestion.
---
This should apply against 2.0.11.
libguile/vm-i-scheme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libguile/vm-i-scheme.c b/libguile/vm-i-scheme.c
index 587aa95..35e618b 100644
--- a/libguile/vm-i-scheme.c
+++ b/libguile/vm-i-scheme.c
@@ -363,7 +363,7 @@ VM_DEFINE_FUNCTION (149, ge, "ge?", 2)
{ \
scm_t_signed_bits rlo, rhi; \
asm ("smull %0, %1, %2, %3\n" \
- : "=r" (rlo), "=r" (rhi) \
+ : "=&r" (rlo), "=&r" (rhi) \
: "r" (SCM_UNPACK (x) - scm_tc2_int), \
"r" (SCM_I_INUM (y))); \
if (SCM_LIKELY (SCM_SRS (rlo, 31) == rhi)) \
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Add "&" asm constraint modifier to ASM_MUL outputs
2014-09-19 22:42 [PATCH 1/1] Add "&" asm constraint modifier to ASM_MUL outputs Rob Browning
@ 2014-09-22 3:39 ` Mark H Weaver
0 siblings, 0 replies; 2+ messages in thread
From: Mark H Weaver @ 2014-09-22 3:39 UTC (permalink / raw)
To: Rob Browning; +Cc: guile-devel
Rob Browning <rlb@defaultvalue.org> writes:
> Without this change, building for arm{hf,el} with gcc-4.9 (Debian
> 4.9.1-14) fails as follows:
>
> /tmp/ccdZTkXQ.s:14591: rdhi, rdlo and rm must all be different
>
> Thanks to Mark H Weaver <mhw@netris.org> for the suggestion.
Sorry, I pushed my own equivalent commit before I saw your email,
a85c78ea1393985fdb6e6678dea19135c553d341 on the stable-2.0 branch.
FYI, the commit log above does not conform to our conventions, so that
would have needed fixing. See the existing logs for examples.
Thanks!
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-22 3:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 22:42 [PATCH 1/1] Add "&" asm constraint modifier to ASM_MUL outputs Rob Browning
2014-09-22 3:39 ` Mark H Weaver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).