From: Mike Gran <spk121@yahoo.com>
To: Mark H Weaver <mhw@netris.org>
Cc: "guile-devel@gnu.org" <guile-devel@gnu.org>
Subject: Re: [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al
Date: Tue, 2 Apr 2013 11:10:44 -0700 (PDT) [thread overview]
Message-ID: <1364926244.74761.YahooMailNeo@web120405.mail.ne1.yahoo.com> (raw)
In-Reply-To: <874nfo24zp.fsf@tines.lan>
> From: Mark H Weaver <mhw@netris.org>
> Thanks for nudging me to do the measurement. To be honest, the original
> patch I posted slowed things down by 4.5%, which I found extremely
> surprising. I fixed it by adding an internal 'static' version of
> 'scm_fill_input'. So for those who doubt the cost of function calls
> though the shared library PLT (which, within a shared library, is
> *every* function call to a non-static function), let this be a lesson.
> That's the only thing that changed here, and it made more than a 4%
> difference, even though the procedure call in question was done only
> once per 4 kilobyte buffer!
> I've attached the new patches. Okay to push now?
I don't think I get a vote, but, I vote yes anyway.
-Mike
next prev parent reply other threads:[~2013-04-02 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 9:59 [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al Mark H Weaver
2013-04-02 12:43 ` Mike Gran
2013-04-02 15:59 ` Ludovic Courtès
2013-04-02 17:54 ` Mark H Weaver
2013-04-02 18:10 ` Mike Gran [this message]
2013-04-03 8:12 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364926244.74761.YahooMailNeo@web120405.mail.ne1.yahoo.com \
--to=spk121@yahoo.com \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).