From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nala Ginrut Newsgroups: gmane.lisp.guile.devel Subject: Re: lua branch Date: Tue, 26 Mar 2013 14:14:01 +0800 Organization: HFG Message-ID: <1364278441.2815.12.camel@Renee-desktop.suse> References: <87fvzipxn7.fsf@Kagami.home> <87boa6pv58.fsf@Kagami.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1364278450 21128 80.91.229.3 (26 Mar 2013 06:14:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Mar 2013 06:14:10 +0000 (UTC) Cc: guile-devel@gnu.org To: Ian Price Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 26 07:14:36 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKN9W-0002dK-NP for guile-devel@m.gmane.org; Tue, 26 Mar 2013 07:14:34 +0100 Original-Received: from localhost ([::1]:52602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKN98-0000HU-Px for guile-devel@m.gmane.org; Tue, 26 Mar 2013 02:14:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKN94-0000HL-32 for guile-devel@gnu.org; Tue, 26 Mar 2013 02:14:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKN93-0006Cs-4C for guile-devel@gnu.org; Tue, 26 Mar 2013 02:14:06 -0400 Original-Received: from mail-pa0-f49.google.com ([209.85.220.49]:36274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKN92-0006Cc-U1 for guile-devel@gnu.org; Tue, 26 Mar 2013 02:14:05 -0400 Original-Received: by mail-pa0-f49.google.com with SMTP id kp14so1196574pab.36 for ; Mon, 25 Mar 2013 23:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:subject:from:to:cc:date:in-reply-to :references:organization:content-type:x-mailer:mime-version :content-transfer-encoding; bh=P4B3RKW3aeTGwcbAC2nKGbN16KJnTE3W0FLr+BPJ184=; b=a9gEZnbNk2njStjaVlQNuWn9zkcTTxsajreqO7r992kY9ODNuhRnZgFlW+nojIXMdW SBxC4du9iwFOuSHGLgVUVpvs8JazBU8Gg9yLiE1zg8op0hbK7+IjZP5zmKyq+jcirjjA ttRReQB5InOgu8PqPsie8J2saDa1INlGmpCY5cKxAcB+tuOXrtddPJcyjW1hWKpaxORm QChuuwl117UK2eyW5Z1Jhmsa/oEVlG8fMgaJaDThDL8xPaS2oXyuR+MEEB5Bq/izDfzy 69q7H9U7dIAFRYY9UqHChOPQEVp4o47IJ/9mEugFunYcrn8LKnuvgqPcqvG9W3YAd+A/ auOw== X-Received: by 10.66.155.102 with SMTP id vv6mr22063410pab.74.1364278444275; Mon, 25 Mar 2013 23:14:04 -0700 (PDT) Original-Received: from [147.2.147.112] ([61.14.130.226]) by mx.google.com with ESMTPS id xc4sm16223211pbc.41.2013.03.25.23.14.02 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 23:14:03 -0700 (PDT) In-Reply-To: <87boa6pv58.fsf@Kagami.home> X-Mailer: Evolution 3.4.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.220.49 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15994 Archived-At: hi ijp! Here're some rough thoughts about the patch: On Tue, 2013-03-26 at 05:50 +0000, Ian Price wrote: > Ian Price writes: > > > I don't know much about Lua, but I think I could do the following. > > 1. Fix the lua-lexer failure. > > 2. Disable or fix[1] the variable-arguments functionality. > > 3. Rebase or merge with modern stable or master > > 4. Fix the errors that arise as a result of 3. > > I have patches for 1 & 2. > + (let* ((old-vararg-function *vararg-function*) + (old-vararg-gensym *vararg-gensym*)) Is 'let' better here? ------------------------ + ;; refers to the gensym for '...' in a function that accepts variable arguments + (define *vararg-gensym* #f) + I know it's consistent with the old code, but maybe parameterize is suggested? ------------------------ Besides, as we talked in IRC, LALR/PEG is better than this manual parser. But I think this lua implementation could work after some patches, so I'm not sure if it's necessary to rewrite it with LALR/PEG. What do you think?