From: Nala Ginrut <nalaginrut@gmail.com>
To: Ian Price <ianprice90@googlemail.com>
Cc: guile-devel@gnu.org
Subject: Re: lua branch
Date: Tue, 26 Mar 2013 14:14:01 +0800 [thread overview]
Message-ID: <1364278441.2815.12.camel@Renee-desktop.suse> (raw)
In-Reply-To: <87boa6pv58.fsf@Kagami.home>
hi ijp!
Here're some rough thoughts about the patch:
On Tue, 2013-03-26 at 05:50 +0000, Ian Price wrote:
> Ian Price <ianprice90@googlemail.com> writes:
>
> > I don't know much about Lua, but I think I could do the following.
> > 1. Fix the lua-lexer failure.
> > 2. Disable or fix[1] the variable-arguments functionality.
> > 3. Rebase or merge with modern stable or master
> > 4. Fix the errors that arise as a result of 3.
>
> I have patches for 1 & 2.
>
+ (let* ((old-vararg-function *vararg-function*)
+ (old-vararg-gensym *vararg-gensym*))
Is 'let' better here?
------------------------
+ ;; refers to the gensym for '...' in a function that accepts variable
arguments
+ (define *vararg-gensym* #f)
+
I know it's consistent with the old code, but maybe parameterize is
suggested?
------------------------
Besides, as we talked in IRC, LALR/PEG is better than this manual
parser. But I think this lua implementation could work after some
patches, so I'm not sure if it's necessary to rewrite it with LALR/PEG.
What do you think?
next prev parent reply other threads:[~2013-03-26 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 4:56 lua branch Ian Price
2013-03-26 5:50 ` Ian Price
2013-03-26 6:14 ` Nala Ginrut [this message]
2013-03-26 6:28 ` Ian Price
2013-03-26 21:52 ` Ludovic Courtès
2013-04-12 14:27 ` Ian Price
2013-04-17 23:09 ` Ian Price
2013-05-21 20:42 ` Phil
2013-05-21 21:25 ` Phil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364278441.2815.12.camel@Renee-desktop.suse \
--to=nalaginrut@gmail.com \
--cc=guile-devel@gnu.org \
--cc=ianprice90@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).