From: nalaginrut <nalaginrut@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Mark H Weaver <mhw@netris.org>, guile-devel@gnu.org
Subject: Re: [PATCH] Add ".guile.sls" and ".sls" to the default %load-extensions
Date: Tue, 06 Nov 2012 10:19:42 +0800 [thread overview]
Message-ID: <1352168382.2654.21.camel@Renee-desktop.suse> (raw)
In-Reply-To: <87liefsqe0.fsf@gnu.org>
hey guys! Should we consider add our specified name, like: .gl or
just .guile?
On Mon, 2012-11-05 at 22:15 +0100, Ludovic Courtès wrote:
> Hi!
>
> Mark H Weaver <mhw@netris.org> skribis:
>
> > I don't think the command-line switch is a good solution. The problem
> > is that even if the main program is not written in R6RS, and even if the
> > main program does not use any R6RS libraries directly, this option might
> > still be needed.
>
> Right, good point.
>
> > I see only two sane options:
> >
> > * Add these load extensions by default, to enable users and Guildhall
> > repository maintainers to easily import R6RS libraries as-is.
> >
> > * Reject the dominant R6RS library naming convention, and force users
> > and guildhall repository maintainers to rename the files to .scm and
> > move *.guile.sls to *.scm.
> >
> > I can live with either of these options, but given the existence of
> > guildhall, I see no good compromise position. IMO, we need to make a
> > decision to either fully embrace or fully reject the R6RS library naming
> > convention.
>
> Yes, makes sense.
>
> Looking at your initial patch, the two extensions were actually searched
>
> My current inclination would be to fully reject it, then. The problem
> is that we’d be adding two stats for each file.
>
> Currently there are two stat(2) for each entry in $GUILE_LOAD_PATH:
>
> stat("/home/ludo/.local/share/guile/site/2.0/ice-9/control.scm", 0x7fff1f4aec20) = -1 ENOENT (No such file or directory)
> stat("/home/ludo/.local/share/guile/site/2.0/ice-9/control", 0x7fff1f4aec20) = -1 ENOENT (No such file or directory)
> stat("/home/ludo/soft/share/guile/site/2.0/ice-9/control.scm", 0x7fff1f4aec20) = -1 ENOENT (No such file or directory)
> stat("/home/ludo/soft/share/guile/site/2.0/ice-9/control", 0x7fff1f4aec20) = -1 ENOENT (No such file or directory)
> stat("/home/ludo/soft/share/guile/2.0/ice-9/control.scm", {st_mode=S_IFREG|0644, st_size=2961, ...}) = 0
>
> (I’m not sure if searching for a file name with no extension is
> intentional. Ideas?)
>
> That would double that.
>
> This is likely to become noticeable with large $GUILE_LOAD_PATH values
> and/or numerous module loads.
>
> WDYT?
>
> Ludo’.
>
next prev parent reply other threads:[~2012-11-06 2:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 3:31 [PATCH] Add ".guile.sls" and ".sls" to the default %load-extensions Mark H Weaver
2012-11-04 16:10 ` Noah Lavine
2012-11-04 20:34 ` Ludovic Courtès
2012-11-04 22:27 ` Andreas Rottmann
2012-11-04 23:32 ` Ludovic Courtès
2012-11-05 0:17 ` Andreas Rottmann
2012-11-05 15:16 ` Ludovic Courtès
2012-11-05 20:48 ` Mark H Weaver
2012-11-05 21:15 ` Ludovic Courtès
2012-11-06 2:19 ` nalaginrut [this message]
2012-11-06 2:36 ` Ian Price
2012-11-06 2:56 ` Ian Price
2012-11-06 5:18 ` Mark H Weaver
2012-11-07 20:28 ` Ludovic Courtès
2012-11-08 2:37 ` Alex Shinn
2012-11-08 22:41 ` Andreas Rottmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352168382.2654.21.camel@Renee-desktop.suse \
--to=nalaginrut@gmail.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).