unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Jan Nieuwenhuizen <janneke-list@xs4all.nl>
To: Neil Jerram <neil@ossau.uklinux.net>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH 4/5] Inline the effect of am/pre-inst-guile
Date: Tue, 22 Mar 2011 21:46:25 +0100	[thread overview]
Message-ID: <1300826785.2341.17.camel@vuurvlieg> (raw)
In-Reply-To: <1300745961-4287-5-git-send-email-neil@ossau.uklinux.net>

Neil Jerram schreef op ma 21-03-2011 om 22:19 [+0000]:

> It's just one variable definition, and in my opinion it confuses,
> rather than helps, the overall build picture to have two names
> (preinstguile and meta/guile) for the same thing.

Ah, but in my cross build recipe, i have something like

   preinstguile=$GUILE_FOR_BUILD

I know this isn't nice, I think preinstguile should go
and we should use $GUILE_FOR_BUILD throughout.

It's just one variable, but one that you can override,

> -	"$(preinstguile)" -l "$(srcdir)/$(snarf_doc).scm" -c "			\
> +	"$(top_builddir_absolute)/meta/guile" -l "$(srcdir)/$(snarf_doc).scm"   \
> +	 -c "			 						\

How do you suggest this works during cross compiling?

Greetings,
Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl  




  reply	other threads:[~2011-03-22 20:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 22:19 Some simple build simplification patches Neil Jerram
2011-03-21 22:19 ` [PATCH 1/5] Remove unused definition of preinstguiletool Neil Jerram
2011-03-21 22:19 ` [PATCH 2/5] GUILE_FOR_BUILD is only needed by meta/guile.in, not by Makefiles Neil Jerram
2011-03-21 22:19 ` [PATCH 3/5] Make explicit that GUILE_FOR_BUILD is only used when cross-compiling Neil Jerram
2011-03-21 22:19 ` [PATCH 4/5] Inline the effect of am/pre-inst-guile Neil Jerram
2011-03-22 20:46   ` Jan Nieuwenhuizen [this message]
2011-03-22 22:08     ` Neil Jerram
2011-03-21 22:19 ` [PATCH 5/5] Remove statements about scripts/* that are no longer true Neil Jerram
2011-03-25 18:37 ` Some simple build simplification patches Andy Wingo
2011-03-25 20:00   ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300826785.2341.17.camel@vuurvlieg \
    --to=janneke-list@xs4all.nl \
    --cc=guile-devel@gnu.org \
    --cc=neil@ossau.uklinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).