unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: "Jose A. Ortega Ruiz" <jao@gnu.org>
To: guile-devel@gnu.org, wingo@pobox.com
Cc: "Jose A. Ortega Ruiz" <jao@gnu.org>
Subject: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062)
Date: Tue, 31 Aug 2010 14:19:03 +0200	[thread overview]
Message-ID: <1283257143-24354-1-git-send-email-jao@gnu.org> (raw)

* module/ice-9/session.scm (submodules): replace implementation to
  use `module-submodules' instead of `module-obarray' (the latter
  doesn't include submodules anymore).

Signed-off-by: Jose A. Ortega Ruiz <jao@gnu.org>
---
 module/ice-9/session.scm |   11 ++---------
 1 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm
index 10ce613..36aeb99 100644
--- a/module/ice-9/session.scm
+++ b/module/ice-9/session.scm
@@ -406,15 +406,8 @@ It is an image under the mapping EXTRACT."
 (define (root-modules)
   (submodules (resolve-module '() #f)))
 
-(define (submodules m)
-  (hash-fold (lambda (name var data)
-	       (let ((obj (and (variable-bound? var) (variable-ref var))))
-		 (if (and (module? obj)
-			  (eq? (module-kind obj) 'directory))
-		     (cons obj data)
-		     data)))
-	     '()
-	     (module-obarray m)))
+(define (submodules mod)
+  (hash-map->list (lambda (k v) v) (module-submodules mod)))
 
 (define apropos-fold-exported
   (make-fold-modules root-modules submodules module-public-interface))
-- 
1.7.1




             reply	other threads:[~2010-08-31 12:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 12:19 Jose A. Ortega Ruiz [this message]
2010-08-31 16:04 ` [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062) Andy Wingo
2010-08-31 20:29   ` Jose A. Ortega Ruiz
2010-08-31 23:11     ` Jose A. Ortega Ruiz
2010-09-01 12:02       ` Ludovic Courtès
2010-09-01 20:58         ` Jose A. Ortega Ruiz
2010-09-01 22:23           ` Ludovic Courtès
2010-09-01 23:30             ` Jose A. Ortega Ruiz
2010-09-03  4:35             ` Andy Wingo
2010-09-04  1:13               ` Jose A. Ortega Ruiz
2010-09-04 17:34                 ` Andy Wingo
2010-09-01  0:16   ` Jose A. Ortega Ruiz
2010-09-02 18:45     ` Jose A. Ortega Ruiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283257143-24354-1-git-send-email-jao@gnu.org \
    --to=jao@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=wingo@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).