From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Matt Wette Newsgroups: gmane.lisp.guile.devel Subject: Re: GNU Guile 2.1.6 released (beta) [numbers.c] Date: Fri, 20 Jan 2017 12:23:24 -0800 Message-ID: <12669E32-5B1B-4FF7-9951-A15A8416013B@gmail.com> References: <87tw8v7pjz.fsf@pobox.com> <49954F94-8294-4339-9276-10793DEBAC6D@gmail.com> <6DD4E83E-6A96-4CBE-8FCE-8D74DFBD3E85@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_4C4D5775-19F1-47B5-922E-6F581E9EB72B" X-Trace: blaine.gmane.org 1484943855 16184 195.159.176.226 (20 Jan 2017 20:24:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2017 20:24:15 +0000 (UTC) Cc: Andy Wingo To: guile-devel Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Jan 20 21:24:10 2017 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUfiz-0002Vf-Vd for guile-devel@m.gmane.org; Fri, 20 Jan 2017 21:23:54 +0100 Original-Received: from localhost ([::1]:57158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUfj4-0001MF-VP for guile-devel@m.gmane.org; Fri, 20 Jan 2017 15:23:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUfik-0001JH-MW for guile-devel@gnu.org; Fri, 20 Jan 2017 15:23:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUfib-0000AC-DT for guile-devel@gnu.org; Fri, 20 Jan 2017 15:23:34 -0500 Original-Received: from mail-pf0-x229.google.com ([2607:f8b0:400e:c00::229]:32824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cUfib-00009j-4N for guile-devel@gnu.org; Fri, 20 Jan 2017 15:23:29 -0500 Original-Received: by mail-pf0-x229.google.com with SMTP id y143so24847066pfb.0 for ; Fri, 20 Jan 2017 12:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=MM+OWB40AChUJkCXsdwuswSC7KTYshNTnyGcisbLsAw=; b=fsLZPoDyu5VFcQKc5dr11GFidWjCyuIIeB61mMgSjzuPj4X+a6wuOCTFGa9wwQgdx6 NTEp181ctPEL22BLa8urH6SgkLdLv2c2n4jAsbhuI/msRczh8nZP0cl+IWjTABXU+H6v B4YQIkG8LpfUokU+p2h0YwhTKAbDc+JqmjyZFlGc6nyyMHROYOp4pYI9HE+/sw4QQJ0L 2qJ3Cyg2regHOJaZRvOWMqsRXD0FGoEnS4WpnRKZejs2V0V/a0QTKgkiWf0lG28btidQ rvzwsW/M4d1hx/vsFmT2YbRpAcUT/0On25Km2Cw1Kbf0xITqk0DDStkMBJ2iCb58fLl0 efFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=MM+OWB40AChUJkCXsdwuswSC7KTYshNTnyGcisbLsAw=; b=jbZUO4UukdKj5qnWA8yvnA/hdzvJyMqqvZoiK6hodoYfECxuikgB6oPty/faVhGCxa JCHIBFnaeKSQkn32tnJmjb7wJV3EoZArzxcpDeReVHaJX4gD6fvazawU8ivt6aFUqeob XL6PtzlmO58OLyZnfUpxl1gA9GqOhyezvVu+GOMjt3ux2w4FXBUsbe/pzX8k1p1d4mCg q9F2MK95U5eulMKADPDOVMyESCcLxeIB6wKQJFIQh563oNyAavMss6H0vJJwPAVewJO+ 5NzqVCwkh5k63BUv2mFspMzoesv85MMQonbwrQgu4Nm2rgMb2ZkIUb2H4cK7B+CCWqKy yaaQ== X-Gm-Message-State: AIkVDXK2nAVysyKYZachNAHj9XFuvLbPO6q+L0qpbzHJqNU0B17/fX8OVSqGavdhPuafEQ== X-Received: by 10.84.171.195 with SMTP id l61mr23983421plb.84.1484943807551; Fri, 20 Jan 2017 12:23:27 -0800 (PST) Original-Received: from nautilus.championbroadband.com (216-165-246-244.championbroadband.com. [216.165.246.244]) by smtp.gmail.com with ESMTPSA id j7sm18763738pfe.84.2017.01.20.12.23.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2017 12:23:26 -0800 (PST) In-Reply-To: <6DD4E83E-6A96-4CBE-8FCE-8D74DFBD3E85@gmail.com> X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::229 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:18868 Archived-At: --Apple-Mail=_4C4D5775-19F1-47B5-922E-6F581E9EB72B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jan 20, 2017, at 11:01 AM, Matt Wette wrote: >=20 >>=20 >> On Jan 19, 2017, at 7:01 PM, Matt Wette > wrote: >>=20 >>=20 >>> On Jan 18, 2017, at 6:26 PM, Andy Wingo > wrote: >>>=20 >>> We are pleased to announce GNU Guile release 2.1.6. >>>=20 >>> Guile 2.1.6 is the sixth pre-release in what will eventually become = the >>> 2.2 release series. We encourage you to test this release and = provide >>> feedback to guile-devel@gnu.org . >>=20 >> Saw this one last round. Mac OS, now gcc-6.3.0: >>=20 >> ;;; ("#i1@-0" 1.0 -0.0) >> FAIL: numbers.test: string->number: valid complex number strings >>=20 >> I am going to see if I can generate the assembly. >=20 > Short story: scm_c_make_polar is broken for the Mac. Guile needs to = decide if it want to use __sincos() on Mac, or suppress optimization, or = ... >=20 a patch, with which make check passes all tests on macOS 10.12.2, aka = Sierra: --- libguile/numbers.c.orig 2017-01-19 16:57:30.000000000 -0800 +++ libguile/numbers.c 2017-01-19 20:20:58.000000000 -0800 @@ -9099,6 +9099,9 @@ #undef FUNC_NAME =20 SCM +#if defined(__APPLE__) && defined(__GNUC__) +__attribute__((optimize("O0"))) +#endif scm_c_make_polar (double mag, double ang) { double s, c; --Apple-Mail=_4C4D5775-19F1-47B5-922E-6F581E9EB72B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Jan 20, 2017, at 11:01 AM, Matt Wette <matt.wette@gmail.com> wrote:


On = Jan 19, 2017, at 7:01 PM, Matt Wette <matt.wette@gmail.com> wrote:


On Jan = 18, 2017, at 6:26 PM, Andy Wingo <wingo@pobox.com> wrote:

We = are pleased to announce GNU Guile release 2.1.6.

Guile 2.1.6 is the sixth pre-release in what will eventually = become the
2.2 release series.  We encourage you to = test this release and provide
feedback to guile-devel@gnu.org.

Saw this one last round.  Mac OS, now = gcc-6.3.0:

;;; = ("#i1@-0" 1.0 -0.0)
FAIL: = numbers.test: string->number: valid complex number = strings

I am going to see = if I can generate the = assembly.

Short story: scm_c_make_polar is broken for the Mac. =  Guile needs to decide if it want to use __sincos() on Mac, or = suppress optimization, or ...


a = patch, with which make check passes all tests on macOS 10.12.2, aka = Sierra:

--- = libguile/numbers.c.orig     2017-01-19 16:57:30.000000000 = -0800
+++ libguile/numbers.c  2017-01-19 = 20:20:58.000000000 -0800
@@ = -9099,6 +9099,9 @@
 #undef FUNC_NAME

 

 SCM
+#if defined(__APPLE__) && = defined(__GNUC__)
+__attribute__((optimize("O0")))
+#endif
 scm_c_make_polar (double mag, = double ang)
 {
   double s, c;

= --Apple-Mail=_4C4D5775-19F1-47B5-922E-6F581E9EB72B--