From: Mike Gran <spk121@yahoo.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [BDW-GC] "Inlined" storage; `scm_take_' functions
Date: Mon, 31 Aug 2009 17:48:42 -0700 [thread overview]
Message-ID: <1251766122.17414.5683.camel@localhost.localdomain> (raw)
In-Reply-To: <874ornldw0.fsf@gnu.org>
On Tue, 2009-09-01 at 02:14 +0200, Ludovic Courtès wrote:
> Hello!
>
> Stringbufs and bytevectors are now always "inlined" in the BDW-GC
> branch [0, 1], which means that there's no cell->buffer indirection,
> which greatly simplifies code (it also takes less room and may slightly
> improve performance).
Neat!
>
> The `scm_take_' functions for strings/symbols/bytevectors are now
> essentially aliases to the corresponding `scm_from_' because we cannot
> advantageously reuse the provided storage.
>
> Should these functions be deprecated or discouraged?
>
codesearch.google.com says that scm_take_ isn't often used by other
projects, but, it is used by lilypond. I think that's reason enough to
leave it in. I'd vote for keeping them and adjusting the docs to say
something like
Like `scm_from_locale_string' and `scm_from_locale_stringn',
respectively, but also immediately frees STR after creating
the Guile string.
Or something like that.
-Mike
next prev parent reply other threads:[~2009-09-01 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 0:14 [BDW-GC] "Inlined" storage; `scm_take_' functions Ludovic Courtès
2009-09-01 0:48 ` Mike Gran [this message]
2009-09-01 8:20 ` Ludovic Courtès
2009-09-08 23:54 ` Neil Jerram
2009-09-09 8:03 ` Ludovic Courtès
2009-09-09 21:38 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251766122.17414.5683.camel@localhost.localdomain \
--to=spk121@yahoo.com \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).