Unicode-capable srfi-14 charsets (f49dbcadf...)

Unicode-capable srfi-14 charsets (f49dbcadf...)

[Mike Gran]

Hi-

I pushed the commit for Unicode-capable srfi-14.  Of all parts necessary
for Unicode, this patch has the largest amount of new code and is most
likely to cause compilation problems.

Since the default charsets such as char-set:lower-case are much larger
in the Unicode scenario, I had to change both the underlying structures
that hold them as well as the print format.  I also had to pregenerate
them, since it was too slow to create them at startup.  So this is also
the part of this project where I've taken the greatest liberties.

Let me know what you think.

-Mik

Re: Unicode-capable srfi-14 charsets (f49dbcadf...)

[Andy Wingo]

On Thu 27 Aug 2009 17:20, Mike Gran <spk121@yahoo.com> writes:

> I pushed the commit for Unicode-capable srfi-14.  Of all parts necessary
> for Unicode, this patch has the largest amount of new code and is most
> likely to cause compilation problems.

On Linux, this now works fine for me; make succeeds, one test fails for
me (utf8 r6rs ports).

On Mac 10.5, I get an exception running the test suite, which actually
stops the test suite: bad argument to setlocale. I don't recall which
file that was in. Apologies for the imprecision, that machine is at
work.

> Since the default charsets such as char-set:lower-case are much larger
> in the Unicode scenario, I had to change both the underlying
> structures that hold them as well as the print format. I also had to
> pregenerate them, since it was too slow to create them at startup. So
> this is also the part of this project where I've taken the greatest
> liberties.

Looks good to me. Ideally over time these will migrate to being
implemented in Scheme. For now, please make that static table const, so
it can be shared between processes, and avoid some relocations at link
time.

Cheers,

Andy
-- 
http://wingolog.org/

Re: Unicode-capable srfi-14 charsets (f49dbcadf...)

[Andy Wingo]

The failing test:

FAIL: r6rs-ports.test: 7.2.7 Input Ports: make-custom-binary-input-port

-- 
http://wingolog.org/

Re: Unicode-capable srfi-14 charsets (f49dbcadf...)

[Ludovic Courtès]

Hi,

I haven't looked in details, but here's a minor glitch (when making
`srfi-14.doc'):

--8<---------------cut here---------------start------------->8---
gawk -f ./guile-func-name-check srfi-14.c
srfi-14.c:707:***Missing or erroneous #undef for scm_char_set_cursor: 
srfi-14.c:737:***Missing or erroneous #undef for scm_char_set_ref: 
srfi-14.c:787:***Missing or erroneous #undef for scm_char_set_cursor_next: 
srfi-14.c:806:***Missing or erroneous #undef for scm_end_of_char_set_p: 
srfi-14.c:946:***Missing or erroneous #undef for scm_char_set_for_each: 
srfi-14.c:1010:***Missing or erroneous #undef for scm_char_set_copy: 
srfi-14.c:1185:***Missing or erroneous #undef for scm_char_set_filter: 
srfi-14.c:1217:***Missing or erroneous #undef for scm_char_set_filter_x: 
srfi-14.c:1350:***Missing or erroneous #undef for scm_char_set_size: 
srfi-14.c:1403:***Missing or erroneous #undef for scm_char_set_to_list: 
srfi-14.c:1448:***Missing or erroneous #undef for scm_char_set_to_string: 
srfi-14.c:1492:***Missing or erroneous #undef for scm_char_set_every: 
srfi-14.c:1637:***Missing or erroneous #undef for scm_char_set_complement: 
srfi-14.c:1819:***Missing or erroneous #undef for scm_char_set_complement_x: 
srfi-14.c:1834:***Missing or erroneous #undef for scm_char_set_union_x: 
srfi-14.c:1849:***Missing or erroneous #undef for scm_char_set_intersection_x: 
srfi-14.c:1864:***Missing or erroneous #undef for scm_char_set_difference_x: 
srfi-14.c:1880:***Missing or erroneous #undef for scm_char_set_xor_x: 
srfi-14.c:1900:***Missing or erroneous #undef for scm_char_set_diff_plus_intersection_x: 
srfi-14.c:1941:***Mismatching FUNC_NAME.  Should be: `#define FUNC_NAME s_scm_debug_char_set'
srfi-14.c:1959:***Missing or erroneous #undef for scm_debug_char_set: 
--8<---------------cut here---------------end--------------->8---

Thanks,
Ludo'.