unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Mike Gran <spk121@yahoo.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guile-devel@gnu.org
Subject: Re: [Guile-commits] GNU Guile branch, master, updated. release_1-9-1-18-g904a78f
Date: Sat, 01 Aug 2009 10:58:29 -0700	[thread overview]
Message-ID: <1249149509.12325.7535.camel@localhost.localdomain> (raw)
In-Reply-To: <87fxcd92pg.fsf@gnu.org>

On Fri, 2009-07-31 at 01:21 +0200, Ludovic Courtès wrote:
> "Michael Gran" <spk121@yahoo.com> writes:
> My remark about user-visibility was actually regarding this commit, not
> the previous one.
> 
> > +#ifndef SCM_WCHAR_DEFINED
> > +typedef scm_t_int32 scm_t_wchar;
> > +#define SCM_WCHAR_DEFINED
> > +#endif
> 
> Why is this #ifdef hack needed?
> 

It was to work around a problem, which, apparently, I can no longer
reproduce.  So, it isn't needed.

> > +#define SCM_MAKE_CHAR(x) ({scm_t_int32 _x = (x);                        \
> > +      _x < 0                                                            \
> > +        ? SCM_MAKE_ITAG8((scm_t_bits)(unsigned char)_x, scm_tc8_char)   \
> > +        : SCM_MAKE_ITAG8((scm_t_bits)_x, scm_tc8_char);})
> 
> This macro uses a GCC extension, which is not acceptable for Guile.  Can
> you please rewrite it in standard C?  (The only risk is multiple
> expansion of X, but that's OK.)

OK.  There was one case of multiple expansion causing side effects, but,
I fixed that.

> Does X < 0 mean ASCII?  And why is it truncated to 8 bits?  A comment
> just above indicating the encoding trick would be handy IMO.

OK.  Wide chars are always positive, but, the upper 128 of signed 8-bit
C chars are negative, which is the reason for that logic.

>> +                  if (i<256)
>> +                    {
>> +                      /* Character is graphic.  Print it.  */
>> +                      scm_putc (i, port);
>> +                    }

> Style (extraneous braces).

Noted.  If that's the standard then so be it.   But, for this case, I
declare, in classic flamewar fashion, that the standard is nonsense.

Thanks,

Mike




  reply	other threads:[~2009-08-01 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1MW9af-0007pM-IW@cvs.savannah.gnu.org>
2009-07-30 23:21 ` [Guile-commits] GNU Guile branch, master, updated. release_1-9-1-18-g904a78f Ludovic Courtès
2009-08-01 17:58   ` Mike Gran [this message]
2009-08-04 16:11     ` Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249149509.12325.7535.camel@localhost.localdomain \
    --to=spk121@yahoo.com \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).