From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Gran Newsgroups: gmane.lisp.guile.devel Subject: Re: [Guile-commits] GNU Guile branch, string-abstraction, updated. feda5bd1c08d69628ec9fdb5577d5c894b70b6e8 Date: Mon, 27 Apr 2009 06:53:36 -0700 Message-ID: <1240840416.3133.230.camel@localhost.localdomain> References: <87mya2pl4n.fsf@inria.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1240840967 9054 80.91.229.12 (27 Apr 2009 14:02:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Apr 2009 14:02:47 +0000 (UTC) Cc: Guile Devel To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 27 16:02:38 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LyRPp-0004oh-KK for guile-devel@m.gmane.org; Mon, 27 Apr 2009 16:02:37 +0200 Original-Received: from localhost ([127.0.0.1]:51856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LyRPp-0001Yu-8i for guile-devel@m.gmane.org; Mon, 27 Apr 2009 10:02:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LyRHB-0008KY-VD for guile-devel@gnu.org; Mon, 27 Apr 2009 09:53:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LyRH9-0008K7-Vy for guile-devel@gnu.org; Mon, 27 Apr 2009 09:53:40 -0400 Original-Received: from [199.232.76.173] (port=35475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LyRH9-0008Jx-7X for guile-devel@gnu.org; Mon, 27 Apr 2009 09:53:39 -0400 Original-Received: from smtp107.prem.mail.sp1.yahoo.com ([98.136.44.62]:28644) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LyRH8-0007wy-Ej for guile-devel@gnu.org; Mon, 27 Apr 2009 09:53:38 -0400 Original-Received: (qmail 40581 invoked from network); 27 Apr 2009 13:53:37 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:Message-Id:Mime-Version:X-Mailer:Content-Transfer-Encoding; b=mdq2FehkvAofWYmx2TpFP+Fz4WFTIMm++VCTVo3KSHEB0rW++n4grGgnyL9U8gdBPmT/Mz6JoW/A26TCntB6TaeMvSruOmmfPtOs4/tDvA78l+cuwlzpQmW2ueeyF4Ic/3LPvC62WDvRiWjOpHZS8JgWAE9byzX1UIYqvkrpySE= ; Original-Received: from unknown (HELO ?192.168.1.64?) (spk121@71.143.114.144 with plain) by smtp107.prem.mail.sp1.yahoo.com with SMTP; 27 Apr 2009 13:53:37 -0000 X-YMail-OSG: CZ_iIpEVM1mnBZBbt9m1M6DmUfBtxVKdBu7z7bvHJ6ugsOprbbaLpQGXsSjPUAbvtTLOrS5L2PgwjS9N9LyVAsLV7eVpOJhbyyCPQ7a8bmfrIrVFvK.8nTGExuT4Li7GIxNaXj73pgoAcsPh1ikd.PpYfY3kaCzA84pFp2VhVGBjOTScs6UNH_Lmw5KmTMy_UhkIjhbZH4zizt4CCNRav7onEKPEFeX0eXJwRCrF9YZxxFPv0_g6obb7pZ4NvdgGtILg.kxMDwzwNB9wYWCp.SBAAY9PlWsPg9eb6wP0KShtGLPp7og- X-Yahoo-Newman-Property: ymail-3 In-Reply-To: <87mya2pl4n.fsf@inria.fr> X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:8467 Archived-At: On Mon, 2009-04-27 at 10:16 +0200, Ludovic Courtès wrote: > Hello, > Is `read_token2 ()' temporary? (I didn't see it mentioned in the log.) > > Otherwise I'd vote for a more descriptive name. > It was meant to be temporary. > > static scm_t_uint32 > > BTW, I'm wondering whether we should have a separate type for wide > chars, to make the intent clearer (say, `scm_t_char'). > OK > > - (pass-if "\\x08 backspace" > > + (pass-if "\\x08; backspace" > > (let ((port (open-output-string))) > > - (display "\x08" port) > > + (display "\x08;" port) > We're introducing subtle incompatibilities here, which we'd rather > avoid, by default at least. Could you make that a reader option? I'm getting there. I pulled this idea of hex escapes out of the R6RS, but, as a standard, I think it is a poor design. Part of the reason for moving hex escapes into their own function in the last push was to try to centralize them, so that the reader option was possible. > > Likewise, I think we should avoid gratuitously changing exception > messages since, unfortunately, they are sort-of part of the API. > I can roll it back if you like. I only changed it because of this line in the Gnu coding standards. "Please do not use the term 'illegal' to refer to erroneous input to a computer program. Please use 'invalid' for this, and reserve the term 'illegal' for activities prohibited by law." > > --- a/test-suite/tests/regexp.test > > +++ b/test-suite/tests/regexp.test > > @@ -22,6 +22,8 @@ > > #:use-module (test-suite lib) > > #:use-module (ice-9 regex)) > > > > +(setlocale LC_ALL "en_US.iso88591") > > The user doesn't necessarily have this locale. Can you instead use > something similar to `under-french-locale-or-unresolved' in `i18n.test' > or `find-latin1-locale' in `srfi-14.test', perhaps moving it to the > `(test-suite lib)' module? If that line ends up remaining more permanent, I will. -Mike Gran