unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Greg Troxel <gdt@ir.bbn.com>
To: Neil Jerram <neil@ossau.uklinux.net>
Cc: Guile Bugs <bug-guile@gnu.org>,
	ludovic.courtes@inria.fr, Greg Troxel <gdt@ir.bbn.com>
Subject: Re: Fix for _Complex_I problems
Date: Tue, 12 Feb 2008 08:22:45 -0500	[thread overview]
Message-ID: <rmifxvyjom2.fsf@fnord.ir.bbn.com> (raw)
In-Reply-To: <87fxw2kl5r.fsf@ossau.uklinux.net> (Neil Jerram's message of "Sat, 09 Feb 2008 19:02:56 +0000")

I cannot test on Solaris; I was reporting a problem that a pkgsrc user had.

The fix looks like it will work, but I am not comfortable with it.  It
mucks up the source with local defines to hack around lack of standards
compliance.  Reading the second diff, there's much less of this.

As far as I can tell, C99 says that if complex.h is there then
_Complex_I has to work.  This is the reason why I'm being cranky about
defining around it.

I would prefer to use the compile test that you wrote, but to undefine
HAVE_COMPLEX_H if it fails, thus falling back to not using the
(therefore broken) complex support at all.  I had meant to suggest this,
and I'm sorry if I didn't manage to do that.

Adding a remedial

#define _Complex_I 1.0fi

to the beginning of numbers.c if _Complex_I weren't defined would seem
less objectionable, and also work.

Thanks for paying attention to this.





  reply	other threads:[~2008-02-12 13:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <534824.44153.qm@web37914.mail.mud.yahoo.com>
     [not found] ` <47A031C6.2030106@dpawson.co.uk>
     [not found]   ` <87odb3uguq.fsf@ossau.uklinux.net>
     [not found]     ` <47A18131.3090503@dpawson.co.uk>
     [not found]       ` <871w7wiep3.fsf@ossau.uklinux.net>
     [not found]         ` <87ir15aw7s.fsf@dellish.bordeaux.inria.fr>
     [not found]           ` <87ve50qpms.fsf_-_@ossau.uklinux.net>
     [not found]             ` <874pcjyfas.fsf@dellish.bordeaux.inria.fr>
     [not found]               ` <87abmbw8du.fsf@ossau.uklinux.net>
2008-02-09 18:54                 ` Fix for _Complex_I problems Neil Jerram
2008-02-09 19:02                   ` Neil Jerram
2008-02-12 13:22                     ` Greg Troxel [this message]
2008-02-12 21:07                       ` Neil Jerram
2008-02-13  7:03                       ` Rainer Tammer
2008-02-12 16:32                     ` Greg Troxel
2008-02-12 20:44                       ` Neil Jerram
2008-02-10 10:08                   ` Rainer Tammer
2008-02-11 20:38                     ` Neil Jerram
2008-02-12  7:31                       ` Rainer Tammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=rmifxvyjom2.fsf@fnord.ir.bbn.com \
    --to=gdt@ir.bbn.com \
    --cc=bug-guile@gnu.org \
    --cc=ludovic.courtes@inria.fr \
    --cc=neil@ossau.uklinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).