unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Andy Wingo <wingo@pobox.com>
To: linasvepstas@gmail.com
Cc: bug-guile@gnu.org
Subject: Re: [PATCH]: deadlock in make_struct()
Date: Mon, 17 Nov 2008 22:41:35 +0100	[thread overview]
Message-ID: <m3y6zijai8.fsf@pobox.com> (raw)
In-Reply-To: <3ae3aa420811161028l4d95d299y9ed997d5bae87a23@mail.gmail.com> (Linas Vepstas's message of "Sun, 16 Nov 2008 12:28:35 -0600")

Hi Linas,

I was about to write about how your patch looked incorrect to me,
because GC could see a half-initialized struct (and potentially sweep
it, with a bad free function); but I just looked back and back into the
history, and could not find why the critical section was there. It has
been there since Jim Blandy imported the whole mess into CVS in 1996.

I would like to say that your patch is OK, but since you don't use
structs very much in your code AFAIK I'm a bit hesitant. Can anyone
think of a reason why this allocation codepath would have SCM_DEFER_INTS
around it?

Andy
-- 
http://wingolog.org/




  reply	other threads:[~2008-11-17 21:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 18:28 [PATCH]: deadlock in make_struct() Linas Vepstas
2008-11-17 21:41 ` Andy Wingo [this message]
2008-11-18 13:34   ` Ludovic Courtès
2008-11-19 22:52     ` Neil Jerram
2008-11-30 19:34       ` Ludovic Courtès
2008-11-18 22:05   ` Linas Vepstas
2008-11-19 12:21     ` Han-Wen Nienhuys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y6zijai8.fsf@pobox.com \
    --to=wingo@pobox.com \
    --cc=bug-guile@gnu.org \
    --cc=linasvepstas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).